Bug 26287 - get_onshelfholds_policy always uses item holdingbranch
Summary: get_onshelfholds_policy always uses item holdingbranch
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 5786
Blocks:
  Show dependency tree / graph
 
Reported: 2020-08-24 13:53 UTC by Andrew Fuerste-Henry
Modified: 2020-08-25 13:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2020-08-24 13:53:59 UTC 
In CirculationRules.pm, the subroutine get_onshelfholds_policy is written to always check the circ rules of the item's holdingbranch. This will not always match a library's desired behavior. Shouldn't this sub follow the ReservesControlBranch value instead?
Comment 1 Jonathan Druart 2020-08-25 13:37:48 UTC 
That would make sense to me, maybe we should ask the mailing list?