While working on bug 25334, I noticed that even if a library is not using any phone transport, the phone column still shows on the overdue status triggers. A similar issue is prevalent in the notice editor. It would be nice if those things were hidden when no phone transport is set up. The same for SMS as well.
I don't them in the notice editor if the prefs are off.
Created attachment 114089 [details] [review] Bug 26953: Hide phone and itiva from "Overdue notice/status triggers" If the prefs are off we should not display the checkboxes Test plan: 1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification 2. Go to the "Overdue notice/status triggers" and confirm that phone and itiva columns are not displayed 3. Turn the prefs on and confirm the checkboxes are now displayed
Created attachment 114090 [details] [review] Bug 26953: Hide phone and itiva from "Overdue notice/status triggers" If the prefs are off we should not display the checkboxes Test plan: 1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification 2. Go to the "Overdue notice/status triggers" and confirm that phone and itiva columns are not displayed 3. Turn the prefs on and confirm the checkboxes are now displayed
(In reply to Jonathan Druart from comment #1) > I don't them in the notice editor if the prefs are off. I don't *see* them in the notice editor if the prefs are off.
> I don't *see* them in the notice editor if the prefs are off. Confirmed, I do not see them either when the prefs are off
Created attachment 114293 [details] [review] Bug 26953: Hide phone and itiva from "Overdue notice/status triggers" If the prefs are off we should not display the checkboxes Test plan: 1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification 2. Go to the "Overdue notice/status triggers" and confirm that phone and itiva columns are not displayed 3. Turn the prefs on and confirm the checkboxes are now displayed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 114621 [details] [review] Bug 26953: Hide phone and itiva from "Overdue notice/status triggers" If the prefs are off we should not display the checkboxes Test plan: 1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification 2. Go to the "Overdue notice/status triggers" and confirm that phone and itiva columns are not displayed 3. Turn the prefs on and confirm the checkboxes are now displayed Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.02
Doesn't apply cleanly to 20.05, please rebase if needed