Bug 26961 - Patron name not shown at checkin if HidePatronName set to "Don't show"
Summary: Patron name not shown at checkin if HidePatronName set to "Don't show"
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 23433
Blocks:
  Show dependency tree / graph
 
Reported: 2020-11-06 19:24 UTC by Andrew Fuerste-Henry
Modified: 2020-12-02 09:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2020-11-06 19:24:34 UTC 
The HidePatronName syspref says: "(Show / Don't show) the names of patrons that have items checked out or on hold on detail pages or the "Place Hold" screen."

This syspref is also hiding the patron name from the checkin screen. If that is the intended behavior, we should clarify this wording. If that's not the intended behavior, we should change the behavior.
Comment 1 Andrew Fuerste-Henry 2020-11-08 01:11:03 UTC 
I've confirmed this is a change between 19.11 and 20.05.
Comment 2 Andrew Fuerste-Henry 2020-11-08 01:22:11 UTC 
Looks like this is caused by a line added in bug 23433. I'm not clear whether or not it was intentional.
Comment 3 Jonathan Druart 2020-12-02 09:42:13 UTC 
The first occurrence of hide_patron_infos_if_needed=1 is coming from 
  commit 258c538e76914e6c2023242b555bb38c6f1970b9
  Bug 22203: Holds modal does not link to patorn account

And I've asked Nick, see bug 22203 comment 9.