Bug 26976 - When renewalsallowed is empty the UI is not correct
Summary: When renewalsallowed is empty the UI is not correct
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-09 14:40 UTC by Jonathan Druart
Modified: 2020-11-20 13:57 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26976: Display 0 if renewalsallowed is not defined (1.14 KB, patch)
2020-11-20 10:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 26976: Display 0 if renewalsallowed is not defined (1.19 KB, patch)
2020-11-20 13:57 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2020-11-09 14:40:23 UTC
On the checkout list I am seeing

"""
4
Not renewable (0 of renewals remaining)
"""

https://snipboard.io/rzOta6.jpg
Comment 1 Jonathan Druart 2020-11-20 10:29:24 UTC
Created attachment 113869 [details] [review]
Bug 26976: Display 0 if renewalsallowed is not defined

If the circulation rule "renewalsallowed" is not set (or an empty
string) then the checkout list displays
(0 of  renewals remaining)
It should display "0 of 0"

Test plan:
Set renewalsallowed to an empty string
Check an item out
Notice the change
Comment 2 David Nind 2020-11-20 13:57:54 UTC
Created attachment 113883 [details] [review]
Bug 26976: Display 0 if renewalsallowed is not defined

If the circulation rule "renewalsallowed" is not set (or an empty
string) then the checkout list displays
(0 of  renewals remaining)
It should display "0 of 0"

Test plan:
Set renewalsallowed to an empty string
Check an item out
Notice the change

Signed-off-by: David Nind <david@davidnind.com>