Bug 27138 - Host items are not included in Z39 results when using EasyAnalytics
Summary: Host items are not included in Z39 results when using EasyAnalytics
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Tomás Cohen Arazi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-03 01:35 UTC by Nick Clemens
Modified: 2021-04-29 19:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27138: Index host items in child records when sending to search engine (11.01 KB, patch)
2020-12-03 01:45 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 27138: (follow-up) Embed host items when performing index from command line (1.33 KB, patch)
2021-01-14 13:24 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 27138: Index host items in child records when sending to search engine (11.08 KB, patch)
2021-02-25 15:15 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 27138: (follow-up) Embed host items when performing index from command line (1.39 KB, patch)
2021-02-25 15:16 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 27138: Index host items in child records when sending to search engine (11.13 KB, patch)
2021-02-25 15:54 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 27138: (follow-up) Embed host items when performing index from command line (1.44 KB, patch)
2021-02-25 15:54 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2020-12-03 01:35:16 UTC
If a library enables EasyAnalytics and links two records in the catalog then the host items show on the child record.

If you search for these records via Z3950 (via zebra directly or the responder) the host items are not shown
Comment 1 Nick Clemens 2020-12-03 01:45:42 UTC
Created attachment 114126 [details] [review]
Bug 27138: Index host items in child records when sending to search engine

On the Koha side we seperate the items from the MARC record but we do put them in
the search engines

For easy analytics we embed host items when displaying results after fetching from the search engine

We can simpify things and improve results by including the host items when indexing

To test:
 1 - Enable EasyAnalyticalRecords
 2 - Find a record in the staff client
 3 - From details page select Edit->Link to host record
 4 - Attach a barcode from a different record
 5 - Search for that barcode in the staff client
 6 - Only host record is returned
 7 - Perform a search that returns the child record and others
 8 - Note the host item is listed on the child record in the results page
 9 - Repeat on OPAC
10 - Note on opac that host item is missing on results
11 - Apply patch
12 - Search for barcode
13 - Child and host record returned on both staff and OPAC
14 - Child record correctly includes host item on staff and OPAC
15 - Connect to the Z3950 responder or zebra directly
     yaz-client localhost:2100
     yaz-client unix:/var/run/koha/kohadev/bibliosocket
16 - Search for the child record
     base biblios
     find record_keyword
     show 1+10
17 - Note the record includes the host item
18 - Repeat tests for Elasticsearch
Comment 2 Nick Clemens 2021-01-14 13:24:48 UTC
Created attachment 115158 [details] [review]
Bug 27138: (follow-up) Embed host items when performing index from command line

The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex

To test:
0 - Follow previous test plan to setup records and set search engine to elasticsearch
1 - perl misc/search_tools/rebuild_elasticsearch.pl -d
2 - Search for the barcode and confirm both records are returned
3 - Confirm the host items are included in the results
Comment 3 Andrew Fuerste-Henry 2021-02-25 15:15:57 UTC
Created attachment 117333 [details] [review]
Bug 27138: Index host items in child records when sending to search engine

On the Koha side we seperate the items from the MARC record but we do put them in
the search engines

For easy analytics we embed host items when displaying results after fetching from the search engine

We can simpify things and improve results by including the host items when indexing

To test:
 1 - Enable EasyAnalyticalRecords
 2 - Find a record in the staff client
 3 - From details page select Edit->Link to host record
 4 - Attach a barcode from a different record
 5 - Search for that barcode in the staff client
 6 - Only host record is returned
 7 - Perform a search that returns the child record and others
 8 - Note the host item is listed on the child record in the results page
 9 - Repeat on OPAC
10 - Note on opac that host item is missing on results
11 - Apply patch
12 - Search for barcode
13 - Child and host record returned on both staff and OPAC
14 - Child record correctly includes host item on staff and OPAC
15 - Connect to the Z3950 responder or zebra directly
     yaz-client localhost:2100
     yaz-client unix:/var/run/koha/kohadev/bibliosocket
16 - Search for the child record
     base biblios
     find record_keyword
     show 1+10
17 - Note the record includes the host item
18 - Repeat tests for Elasticsearch

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 4 Andrew Fuerste-Henry 2021-02-25 15:16:01 UTC
Created attachment 117334 [details] [review]
Bug 27138: (follow-up) Embed host items when performing index from command line

The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex

To test:
0 - Follow previous test plan to setup records and set search engine to elasticsearch
1 - perl misc/search_tools/rebuild_elasticsearch.pl -d
2 - Search for the barcode and confirm both records are returned
3 - Confirm the host items are included in the results

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 5 Andrew Fuerste-Henry 2021-02-25 15:54:04 UTC
Created attachment 117346 [details] [review]
Bug 27138: Index host items in child records when sending to search engine

On the Koha side we seperate the items from the MARC record but we do put them in
the search engines

For easy analytics we embed host items when displaying results after fetching from the search engine

We can simpify things and improve results by including the host items when indexing

To test:
 1 - Enable EasyAnalyticalRecords
 2 - Find a record in the staff client
 3 - From details page select Edit->Link to host record
 4 - Attach a barcode from a different record
 5 - Search for that barcode in the staff client
 6 - Only host record is returned
 7 - Perform a search that returns the child record and others
 8 - Note the host item is listed on the child record in the results page
 9 - Repeat on OPAC
10 - Note on opac that host item is missing on results
11 - Apply patch
12 - Search for barcode
13 - Child and host record returned on both staff and OPAC
14 - Child record correctly includes host item on staff and OPAC
15 - Connect to the Z3950 responder or zebra directly
     yaz-client localhost:2100
     yaz-client unix:/var/run/koha/kohadev/bibliosocket
16 - Search for the child record
     base biblios
     find record_keyword
     show 1+10
17 - Note the record includes the host item
18 - Repeat tests for Elasticsearch

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Michael Sutherland <sudrland@vt.edu>
Comment 6 Andrew Fuerste-Henry 2021-02-25 15:54:07 UTC
Created attachment 117347 [details] [review]
Bug 27138: (follow-up) Embed host items when performing index from command line

The previous patch made sure host items were embedded when indexes were performed inside of Koha (catalg edits, checkins, etc.) but did not affect a command line reindex

To test:
0 - Follow previous test plan to setup records and set search engine to elasticsearch
1 - perl misc/search_tools/rebuild_elasticsearch.pl -d
2 - Search for the barcode and confirm both records are returned
3 - Confirm the host items are included in the results

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>

Signed-off-by: Michael Sutherland <sudrland@vt.edu>