Bug 27317 - (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
Summary: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 27127
Blocks:
  Show dependency treegraph
 
Reported: 2020-12-30 14:06 UTC by Fridolin Somers
Modified: 2021-01-05 14:20 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:
21.05.00,20.11.01


Attachments
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t (1.25 KB, patch)
2020-12-30 14:09 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t (1.35 KB, patch)
2020-12-30 14:43 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t (1.41 KB, patch)
2020-12-30 14:52 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2020-12-30 14:06:29 UTC
Bug 27127 changed  Koha::BackgroundJob->messages to return arrayref instead of array.
This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on :
  not ok 10 - 10 messages generated
Comment 1 Fridolin Somers 2020-12-30 14:09:28 UTC
Created attachment 114744 [details] [review]
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t

Bug 27127 changed  Koha::BackgroundJob->messages to return arrayref instead of array.
This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on :
  not ok 10 - 10 messages generated

Test plan :
prove t/db_dependent/Koha/BackgroundJobs.t
Comment 2 Tomás Cohen Arazi 2020-12-30 14:43:04 UTC
Created attachment 114745 [details] [review]
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t

Bug 27127 changed  Koha::BackgroundJob->messages to return arrayref instead of array.
This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on :
  not ok 10 - 10 messages generated

Test plan :
prove t/db_dependent/Koha/BackgroundJobs.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: I fixed the indentation of the test label.
Comment 3 Victor Grousset/tuxayo 2020-12-30 14:52:21 UTC
Created attachment 114746 [details] [review]
Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t

Bug 27127 changed  Koha::BackgroundJob->messages to return arrayref instead of array.
This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on :
  not ok 10 - 10 messages generated

Test plan :
prove t/db_dependent/Koha/BackgroundJobs.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: I fixed the indentation of the test label.
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Tomás Cohen Arazi 2020-12-30 15:07:05 UTC
Pushed, to end the year with happy Jenkins.

Thanks everyone!
Comment 5 Fridolin Somers 2021-01-05 08:42:15 UTC
Pushed to 20.11.x for 20.11.01
Comment 6 Andrew Fuerste-Henry 2021-01-05 14:20:56 UTC
Missing dependencies for 20.05, not backporting.