Bug 27331 - fr-FR/1-Obligatoire/authorised_values.sql is invalid
Summary: fr-FR/1-Obligatoire/authorised_values.sql is invalid
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: rel_20_11_candidate
Depends on: 25534
Blocks: 17809
  Show dependency treegraph
 
Reported: 2021-01-04 13:43 UTC by Jonathan Druart
Modified: 2021-01-05 14:21 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
21.05.00,20.11.01


Attachments
Bug 27331: (bug 27331 follow-up) Fix syntax error in authorised_values.sql for fr-FR (1.97 KB, patch)
2021-01-04 13:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 27331: (bug 27331 follow-up) Fix syntax error in authorised_values.sql for fr-FR (2.04 KB, patch)
2021-01-04 14:15 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2021-01-04 13:43:44 UTC
ERROR 1064 (42000) at line 724: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '+
+INSERT INTO authorised_values (category, authorised_value, lib) VALUES ('HOLD' at line 1
Comment 1 Jonathan Druart 2021-01-04 13:45:39 UTC
Created attachment 114789 [details] [review]
Bug 27331: (bug 27331 follow-up) Fix syntax error in authorised_values.sql for fr-FR

ERROR 1064 (42000) at line 724: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '+
+INSERT INTO authorised_values (category, authorised_value, lib) VALUES ('HOLD' at line 1
Comment 2 Kyle M Hall 2021-01-04 13:54:02 UTC
File appears to still be invalid do to unrelated issues:
ERROR 1062 (23000) at line 121: Duplicate entry 'COUNTRY-ER' for key 'av_uniq'

INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`) VALUES ( 'COUNTRY', 'ER', 'Érythrée');
INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`) VALUES ( 'COUNTRY', 'ER', 'Allemagne');
Comment 3 Jonathan Druart 2021-01-04 14:11:29 UTC
(In reply to Kyle M Hall from comment #2)
> File appears to still be invalid do to unrelated issues:
> ERROR 1062 (23000) at line 121: Duplicate entry 'COUNTRY-ER' for key
> 'av_uniq'
> 
> INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`)
> VALUES ( 'COUNTRY', 'ER', 'Érythrée');
> INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`)
> VALUES ( 'COUNTRY', 'ER', 'Allemagne');

Yes, it's related to bug 17809 that I am about to push :)
Comment 4 Jonathan Druart 2021-01-04 14:14:16 UTC
But then it's not blocker I guess.
Comment 5 Kyle M Hall 2021-01-04 14:15:34 UTC
Created attachment 114791 [details] [review]
Bug 27331: (bug 27331 follow-up) Fix syntax error in authorised_values.sql for fr-FR

ERROR 1064 (42000) at line 724: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '+
+INSERT INTO authorised_values (category, authorised_value, lib) VALUES ('HOLD' at line 1

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Jonathan Druart 2021-01-04 15:34:39 UTC
Pushed to master for 21.05, thanks to everybody involved!
Comment 7 Fridolin Somers 2021-01-05 08:20:44 UTC
Pushed to 20.11.x for 20.11.01
Comment 8 Andrew Fuerste-Henry 2021-01-05 14:21:41 UTC
Missing dependencies, not backported to 20.05