Bug 27405 - Update intranet-tmpl/prog/en/modules/pos/register.tt for ACC2
Summary: Update intranet-tmpl/prog/en/modules/pos/register.tt for ACC2
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Catherine
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 26926
  Show dependency treegraph
 
Reported: 2021-01-12 10:17 UTC by Martin Renvoize
Modified: 2021-02-23 11:51 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 27405: update file for ACC2 (1.40 KB, patch)
2021-01-20 01:02 UTC, Catherine
Details | Diff | Splinter Review
Bug 27405: update file for ACC2 (1.37 KB, patch)
2021-01-20 21:40 UTC, Catherine
Details | Diff | Splinter Review
Bug 27405: Update koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for ACC2 (2.33 KB, patch)
2021-02-20 23:07 UTC, David Nind
Details | Diff | Splinter Review
Bug 27405: (follow up) Updates to accommodate currency entry (1.77 KB, patch)
2021-02-20 23:07 UTC, David Nind
Details | Diff | Splinter Review
Bug 27405: Update koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for ACC2 (2.33 KB, patch)
2021-02-23 11:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 27405: (follow up) Updates to accommodate currency entry (1.82 KB, patch)
2021-02-23 11:51 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2021-01-12 10:17:59 UTC
We need to replace number type inputs in intranet-tmpl/prog/en/modules/pos/register.tt as per ACC2 guidelines.
Comment 1 Catherine 2021-01-20 01:02:14 UTC Comment hidden (obsolete)
Comment 2 Catherine 2021-01-20 21:40:47 UTC Comment hidden (obsolete)
Comment 3 David Nind 2021-02-20 23:07:37 UTC
Created attachment 117119 [details] [review]
Bug 27405: Update koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for ACC2

This replaces the number type input in
intranet-tmpl/prog/en/modules/pos/register.tt so that it is
consistent with ACC2 guidelines.

Test plan:
1. Enable the EnablePointOfSale (set to Enable) and UseCashRegisters
   (set to Use) system preferences.
2. Add a new cash register for a library (Home > Point of sale > Create
   a new cash register)
3. Add some sample items for sale (Home > Point of sale > Configure
   items for purchase)
4. Add some sales (Home > Point of sale > Add some items, enter a
   payment and sleect Confirm)
5. Issue a refund (Home > Point of sale > Register details > select
   Issue refund for an item)
6. Try to enter text, numbers with several decimal places, and , or
   multiple .
7. Apply the patch.
8. Repeat steps 4-6 - should continue to function as expected, with
   appropriate warning messages for invalid entries.
9. Search koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for
   input type="number" - there should be no occurences.
10. Sign off!

Sponsored by Catalyst IT

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2021-02-20 23:07:40 UTC
Created attachment 117120 [details] [review]
Bug 27405: (follow up) Updates to accommodate currency entry

This patch makes two modifications to allow the entry of
currency strings (for example, 1.25) so that it is consistent with other
payment entry forms.

- Inputmode changed to "decimal"
- Regex pattern changed to "^\d+(\.\d{2})?$" as found in
  admin/debit_types.tt

To test, apply the patch and test entry of various strings in the manual
invoice "amount" field. Confirm that the field only accepts digits or
digits followed by a decimal and two digits.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2021-02-20 23:10:03 UTC
Comment on attachment 115463 [details] [review]
Bug 27405: update file for ACC2

I've:
- Added steps to the test plan so you can test register.tt
- Updated the title in the commit message so that it matches guidelines (Bug XXXX:   
  Commit title).
- Added a follow up to match other similar bugs - Bug 27408 and 
  Bug 27410.

Have left as requiring sign off.
Comment 6 Owen Leonard 2021-02-23 11:51:15 UTC
Created attachment 117195 [details] [review]
Bug 27405: Update koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for ACC2

This replaces the number type input in
intranet-tmpl/prog/en/modules/pos/register.tt so that it is
consistent with ACC2 guidelines.

Test plan:
1. Enable the EnablePointOfSale (set to Enable) and UseCashRegisters
   (set to Use) system preferences.
2. Add a new cash register for a library (Home > Point of sale > Create
   a new cash register)
3. Add some sample items for sale (Home > Point of sale > Configure
   items for purchase)
4. Add some sales (Home > Point of sale > Add some items, enter a
   payment and sleect Confirm)
5. Issue a refund (Home > Point of sale > Register details > select
   Issue refund for an item)
6. Try to enter text, numbers with several decimal places, and , or
   multiple .
7. Apply the patch.
8. Repeat steps 4-6 - should continue to function as expected, with
   appropriate warning messages for invalid entries.
9. Search koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for
   input type="number" - there should be no occurences.
10. Sign off!

Sponsored by Catalyst IT

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Owen Leonard 2021-02-23 11:51:17 UTC
Created attachment 117196 [details] [review]
Bug 27405: (follow up) Updates to accommodate currency entry

This patch makes two modifications to allow the entry of
currency strings (for example, 1.25) so that it is consistent with other
payment entry forms.

- Inputmode changed to "decimal"
- Regex pattern changed to "^\d+(\.\d{2})?$" as found in
  admin/debit_types.tt

To test, apply the patch and test entry of various strings in the manual
invoice "amount" field. Confirm that the field only accepts digits or
digits followed by a decimal and two digits.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>