Created attachment 119541 [details] [review] Bug 28144: Check if issue_id defined Historical OVERDUE fines may not have an issue_id - this causes flooding of the logs when calling update fine Trivial change, reading the code should be enough, but test plan below To test: 1 - Create some fines without an issue_id - Either checkout an old version of Koha and add manually or - Checkout some items (backdated) to a patron, run fines.pl then UPDATE accountlines SET issue_id = NULL; 2 - Checkout a backdated item with fines in the circ rule to the same patron 3 - Run fines.pl 4 - Note the errors 5 - Apply patch 6 - Repeat and note no errors
Created attachment 120175 [details] [review] Bug 28144: Check if issue_id defined Historical OVERDUE fines may not have an issue_id - this causes flooding of the logs when calling update fine Trivial change, reading the code should be enough, but test plan below To test: 1 - Create some fines without an issue_id - Either checkout an old version of Koha and add manually or - Checkout some items (backdated) to a patron, run fines.pl then UPDATE accountlines SET issue_id = NULL; 2 - Checkout a backdated item with fines in the circ rule to the same patron 3 - Run fines.pl 4 - Note the errors 5 - Apply patch 6 - Repeat and note no errors Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, going straight for PQA.
Created attachment 120220 [details] [review] Bug 28144: Add a regression test
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.06
Pushed to 20.05.x for 20.05.12
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.