Bug 24378 updated the AUTO_RENEWALS notice to formate the date as a due date, however, it seem to have an error: [% checkout.date_due as_due_date => 1 %] Generates an error: ERROR PROCESSING TEMPLATE: file error - parse error - input text line 18: unexpected token (as_due_date) [% checkout.date_due as_due_date => 1 %] at test.pl line 18. I think it should be: [% checkout.date_due | $KohaDates as_due_date => 1%]
Created attachment 120292 [details] [review] Bug 28258: Update bad formatting in AUTO_RENEWALS notice To test: -Look at the AUTO_RENEWALS notice and see the syntax [% checkout.date_due as_due_date => 1 %] -Apply patch, updatedatabase -Look at the AUTO_RENEWALS notice and see the syntax [% checkout.date_due | $KohaDates as_due_date => 1%]
Oops, sorry!
Created attachment 120296 [details] [review] Bug 28258: Update bad formatting in AUTO_RENEWALS notice To test: -Look at the AUTO_RENEWALS notice and see the syntax [% checkout.date_due as_due_date => 1 %] -Apply patch, updatedatabase -Look at the AUTO_RENEWALS notice and see the syntax [% checkout.date_due | $KohaDates as_due_date => 1%] Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 120297 [details] [review] Bug 28258: Fix existing occurrence I think it's good to fix the original problem as well Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 120301 [details] [review] Bug 28258: Update bad formatting in AUTO_RENEWALS notice To test: -Look at the AUTO_RENEWALS notice and see the syntax [% checkout.date_due as_due_date => 1 %] -Apply patch, updatedatabase -Look at the AUTO_RENEWALS notice and see the syntax [% checkout.date_due | $KohaDates as_due_date => 1%] Additional test: 1 - Checkout an item to a patron 2 - Find their borrowernumber, the itemnumber, and the biblionumber 3 - Use the get_prepared_letter script to test the letter content perl misc/devel/get_prepared_letter.pl --module circulation --letter-code AUTO_RENEWALS --tables="{\"borrowers\": 5,\"issues\": 1040,\"items\": 1040,\"biblio\": 2 }" Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 120302 [details] [review] Bug 28258: Fix existing occurrence I think it's good to fix the original problem as well Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 21.05, thanks to everybody involved!
Pushed to 20.11.x for 20.11.06
note: was pushed to 20.05.x for 20.05.12
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.