Add the next release team :)
Created attachment 121359 [details] [review] Bug 28442: Add 21.11 release team to teams.yaml
Created attachment 121360 [details] [review] Bug 28442: Update template for new roles
Created attachment 121362 [details] [review] Bug 28442: Add 21.11 release team to teams.yaml Add the 21.11 release team. Test plan 1/ Check against https://wiki.koha-community.org/wiki/Release_Teams
Created attachment 121363 [details] [review] Bug 28442: Update template for new roles We have multiple accessibility advocates this cycle, so we needed to adapt the template. I've also added the meeting facilitator as a case but not added to the team block as a whole.. seeking opinions, perhaps wait and see if it lasts more than a cycle before adding it fully?
Created attachment 121364 [details] Screenshot of outcome
2 quick things from checking the screenshot: - Sorting of entries appears random in QA team/groups with more than 2 - Missing Accessibility advocate role for 21.05
Created attachment 121375 [details] [review] Bug 28442: Fix 'accessibility_advocate' for current release The accessibility_advocate block was positioned incorrectly so wasn't appearing properly for the current stable releases, only the development/maintainter block. This patch fixes that issue
(In reply to Katrin Fischer from comment #6) > 2 quick things from checking the screenshot: > > - Sorting of entries appears random in QA team/groups with more than 2 > - Missing Accessibility advocate role for 21.05 Good catch on the accessibility advocate role; Fixed in the follow-up. The order of the names in each listed role is sorted by when they signed up on the Wiki.. it follows the order in the yaml file, so could be easily switched to name alpha sorted.. I'm not sure what we've done in the past.. I 'think' I generally took the wiki page as gospel.
I think it could be nice to have some default sorting, the wiki is very arbitrary, alphabetic in some way is usually deceived as "everyone is equally important".
Created attachment 121385 [details] [review] Bug 28442: Add 21.11 release team to teams.yaml Add the 21.11 release team. Test plan 1/ Check against https://wiki.koha-community.org/wiki/Release_Teams
Created attachment 121386 [details] [review] Bug 28442: Update template for new roles We have multiple accessibility advocates this cycle, so we needed to adapt the template. I've also added the meeting facilitator as a case but not added to the team block as a whole.. seeking opinions, perhaps wait and see if it lasts more than a cycle before adding it fully?
Created attachment 121387 [details] [review] Bug 28442: Fix 'accessibility_advocate' for current release The accessibility_advocate block was positioned incorrectly so wasn't appearing properly for the current stable releases, only the development/maintainter block. This patch fixes that issue
Created attachment 121388 [details] [review] Bug 28442: Sort by lastname for array type roles
OK.. if you want to see the results as part of testing, you'll need to temporarily set Koha.pm version to a 21.05.something value and manually update systempreferences version to match.. That'll fake the upgrade so Koha thinks it's already on a stable 21.05.x release and show you the updated about page.
Pushed to master for 21.05, thanks to everybody involved!
This must be backported into all stables.
ok, will try to get the chain of deps for 20.05 oldoldstable (hopefully, 19.11 oldoldoldstable will also be able to do so) bug 28442 => bug 28386 => bug 26621 => bug 26394 ^^"
Pushed to 20.11.x for 20.11.07
Backported: Pushed to 20.05.x branch for 20.05.13
Will backport for 19.11.20 (next release in July) as I believe there is currently a string freeze so this bug should not be backported now?
You are right! Nice catch, thanks. It's indeed string freeze. Reverted. Yesterday I even though about paying attention to that. But happily forgot it when actually backporting stuff ^^"
Backported: Pushed to 20.05.x branch for 20.05.14
Backported to 19.11.x for 19.11.20