Bug 28451 - Message queue field "from_address" does not always get populated
Summary: Message queue field "from_address" does not always get populated
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-25 15:04 UTC by Kyle M Hall
Modified: 2021-05-25 19:36 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2021-05-25 15:04:14 UTC
The message_queue table column "from_address" does not always get populated. We should either make the EnqueueLetter parameter 'from_address' mandatory, or (preferably) derive the correct from address from the letter's branchcode. If the letter has no branchcode, I imagine we should use either the KohaAdminEmailAddress or the patron's home library's email address.
Comment 1 Christopher Brannon 2021-05-25 19:36:37 UTC
Per our previous conversations, it sounds like sometimes this field doesn't get populated because it is a digest, and items may be from multiple libraries.

1) The from address should be from whatever library signs the notification ([% branchname %]).
2) If the notice is a digest and not from any particular library, it should be from the patron's home library.  This should also apply to [% branchname %] if used in the notice.
3) It should only use the KohaAdminEmailAddress if 1 & 2 can't supply an e-mail address.