Typo: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:1392 Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?
Created attachment 125887 [details] [review] Bug 28470: Typo: Are you sure you with to chart this report? This patch corrects the text of a warning on the report results page, from this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ...to this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you want to chart this report?") To test, apply the patch and go to Reports -> Use saved. - Run a report which, unlimited, will return more than 1000 rows. - Click the "Fetch all data for chart" button. - You should be asked for confirmation. Check that the text is correct.
Created attachment 125952 [details] [review] Bug 28470: Typo: Are you sure you with to chart this report? This patch corrects the text of a warning on the report results page, from this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ...to this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you want to chart this report?") To test, apply the patch and go to Reports -> Use saved. - Run a report which, unlimited, will return more than 1000 rows. - Click the "Fetch all data for chart" button. - You should be asked for confirmation. Check that the text is correct. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 126022 [details] [review] Bug 28470: Typo: Are you sure you with to chart this report? This patch corrects the text of a warning on the report results page, from this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you with to chart this report?") ...to this: _("Fetching full chart data for reports with many rows can cause performance issues. Are you sure you want to chart this report?") To test, apply the patch and go to Reports -> Use saved. - Run a report which, unlimited, will return more than 1000 rows. - Click the "Fetch all data for chart" button. - You should be asked for confirmation. Check that the text is correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.12
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.