On patrons check out or details page, after renewing loans they don't sort correctly when clicking on "Date due" tab. Page has to be reloaded so that sorting works. To test: 1. Add 3 loans for patron. 2. Change date dues so you they are e.g. 07/01, 07/02, 07/04 3. Make sure you have renewal period set e.g. 5 days and check your RenewalPeriodBase syspref (I use current date there) 4. Renew loan with date due on 07/01, it should now be 07/07 3. Sort loans by date due => Note that order from top to bottom is 07/04->07/02->07/07 or 07/07->07/02->07/04, not 07/02->07/04->07/07 as one would assumme.
Created attachment 122543 [details] [review] Bug 28653: Add new method RefreshIssuesTable On patrons check out or details page, after renewing loans they don't sort correctly when clicking on "Date due" tab. Page has to be reloaded so that sorting works. This patch adds new method RefreshIssuesTable to checkouts.js. When loans are renewed or checked in, issues table is reloaded to and due dates are sorted correctly. To test: 1. Add 3 loans for patron. 2. Change due dates so you they are e.g. 07/01, 07/02, 07/04 3. Make sure you have renewal period set e.g. 5 days and check your RenewalPeriodBase syspref (I use current date there) 4. Renew loan with date due on 07/01, it should now be 07/07 5. Sort loans by date due => Note that order from top to bottom is 07/04->07/02->07/07 or 07/07->07/02->07/04, not 07/02->07/04->07/07 as one would assume. 6. Apply patch and repeat. => Note that issues table is reloaded ("Loading..." pop-up is displayed) and that due dates are in correct order. Sponsored-by: Koha-Suomi Oy
Created attachment 123706 [details] [review] Bug 28653: Add new method RefreshIssuesTable On patrons check out or details page, after renewing loans they don't sort correctly when clicking on "Date due" tab. Page has to be reloaded so that sorting works. This patch adds new method RefreshIssuesTable to checkouts.js. When loans are renewed or checked in, issues table is reloaded to and due dates are sorted correctly. To test: 1. Add 3 loans for patron. 2. Change due dates so you they are e.g. 07/01, 07/02, 07/04 3. Make sure you have renewal period set e.g. 5 days and check your RenewalPeriodBase syspref (I use current date there) 4. Renew loan with date due on 07/01, it should now be 07/07 5. Sort loans by date due => Note that order from top to bottom is 07/04->07/02->07/07 or 07/07->07/02->07/04, not 07/02->07/04->07/07 as one would assume. 6. Apply patch and repeat. => Note that issues table is reloaded ("Loading..." pop-up is displayed) and that due dates are in correct order. Sponsored-by: Koha-Suomi Oy Signed-off-by: kelly <kelly@bywatersolutions.com>
Created attachment 124815 [details] [review] Bug 28653: Add new method RefreshIssuesTable On patrons check out or details page, after renewing loans they don't sort correctly when clicking on "Date due" tab. Page has to be reloaded so that sorting works. This patch adds new method RefreshIssuesTable to checkouts.js. When loans are renewed or checked in, issues table is reloaded to and due dates are sorted correctly. To test: 1. Add 3 loans for patron. 2. Change due dates so you they are e.g. 07/01, 07/02, 07/04 3. Make sure you have renewal period set e.g. 5 days and check your RenewalPeriodBase syspref (I use current date there) 4. Renew loan with date due on 07/01, it should now be 07/07 5. Sort loans by date due => Note that order from top to bottom is 07/04->07/02->07/07 or 07/07->07/02->07/04, not 07/02->07/04->07/07 as one would assume. 6. Apply patch and repeat. => Note that issues table is reloaded ("Loading..." pop-up is displayed) and that due dates are in correct order. Sponsored-by: Koha-Suomi Oy Signed-off-by: kelly <kelly@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Created attachment 124816 [details] [review] Bug 28653: (QA follow-up) Remove debug message used during development Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Patches will be squashed when pushed.
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.11
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.
We should update the number of checkouts in the tab.