If UseCirculationDesks is enabled, the link to Desks shows up in the "Patrons and circ" section on admin homepage but in the "Basic Parameters" on the sidebar. We should move it on the sidebar.
Created attachment 123064 [details] [review] Bug 28733: Correct position of desks link in admin menu This patch moves the "Desks" link from the "Basic parameters" section to the "Patrons and circulation" section, matching the category of the link on the Administration home page. To test, apply the patch and go to an administration page which includes the left-hand navigation sidebar, e.g. Administration -> Libraries. In the sidebar, the "Desks" link should be in the "Patrons and circulation" section, under "Item circulation alterts," matching its position on the Administration home page.
Created attachment 123065 [details] [review] Bug 28733: Correct position of desks link in admin menu This patch moves the "Desks" link from the "Basic parameters" section to the "Patrons and circulation" section, matching the category of the link on the Administration home page. To test, apply the patch and go to an administration page which includes the left-hand navigation sidebar, e.g. Administration -> Libraries. In the sidebar, the "Desks" link should be in the "Patrons and circulation" section, under "Item circulation alterts," matching its position on the Administration home page. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 123160 [details] [review] Bug 28733: Correct position of desks link in admin menu This patch moves the "Desks" link from the "Basic parameters" section to the "Patrons and circulation" section, matching the category of the link on the Administration home page. To test, apply the patch and go to an administration page which includes the left-hand navigation sidebar, e.g. Administration -> Libraries. In the sidebar, the "Desks" link should be in the "Patrons and circulation" section, under "Item circulation alterts," matching its position on the Administration home page. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
admin/desks.pl needs the parameters.manage_libraries subpermissions.
(In reply to Jonathan Druart from comment #4) > admin/desks.pl needs the parameters.manage_libraries subpermissions. Argh. Thx for catching that.
Created attachment 123193 [details] [review] Bug 28733: (follow-up) Add manage_libraries permission check
Patches will be squashed when pushed.
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.03
Pushed to 20.11.x for 20.11.09
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.