We should add Chad Rosenburg and Michal Kuhn with their roles as newsletter editors to the about page.
My name is Michael Kuhn :-)
Sorry for the typo!
Hmm, they're listed in the team.yaml but not displayed.. I'll take a look.
Created attachment 127001 [details] [review] Bug 28904: Add newsletter editor to about page display
Created attachment 127002 [details] [review] Bug 28904: Update team list to include newsletter editors It seems we stopped recording the newsletter editor as part of the team for a while :(. Chad did it from 16.05 to 20.11 as far as I can tell.
(In reply to Martin Renvoize from comment #5) > Created attachment 127002 [details] [review] [review] > Bug 28904: Update team list to include newsletter editors > > It seems we stopped recording the newsletter editor as part of the team > for a while :(. Chad did it from 16.05 to 20.11 as far as I can tell. I listed all Koha newsletters here: http://adminkuhn.ch/wiki/Koha_Community_Newsletter These were the editors: * Nicole C. Engard from January 2010 until July 2011 * Daniel Grobani from August 2011 until November 2013 * Chad Roseburg from December 2013 until November 2020 * Michael Kuhn since December 2020
Created attachment 127010 [details] [review] Bug 28904: Update team list to include newsletter editors It seems we stopped recording the newsletter editor as part of the team for a while :(.
Thanks Michael.. updated my second patch from your dates.
Created attachment 127019 [details] [review] Bug 28904: Add newsletter editor to about page display Signed-off-by: David Nind <david@davidnind.com>
Created attachment 127020 [details] [review] Bug 28904: Update team list to include newsletter editors It seems we stopped recording the newsletter editor as part of the team for a while :(. Signed-off-by: David Nind <david@davidnind.com>
Tested by: 1. Checking About Koha > Koha team for newsletter => one entry 2. Applied the patch 3. Checked Koha team page again => updated with those who filled the role and the releases (as per comment #6 and the patch)
I might be missing something, but for me the entry in the "Current maintenance team" for Newsletter remains empty (label shows, but no name). Can you please check? Otherwise this looks really good.
Created attachment 127150 [details] [review] Bug 28904: Fix typo and display Fix typo in template: Newletter => Newsletter Fix latest newsletter editor definition.. it's a has not an array.
Good catch Katrin!.. I'd made a couple of mistakes... A typo in the template.. it's "Newsletter" not "Newletter".. and I'd defined the most recent editor in an array not a hash key.. hence not displaying as expected. Follow-up fixes both issues. Back to NQA
Created attachment 127152 [details] [review] Bug 28904: Add newsletter editor to about page display Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 127153 [details] [review] Bug 28904: Update team list to include newsletter editors It seems we stopped recording the newsletter editor as part of the team for a while :(. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 127154 [details] [review] Bug 28904: Fix typo and display Fix typo in template: Newletter => Newsletter Fix latest newsletter editor definition.. it's a has not an array. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Pushed to 20.11.x for 20.11.12
Backported: Pushed to 20.05.x branch for 20.05.18
Could someone please help me with what I should do with this bug for 19.11.x? I think it is too late this month to add it to 19.11.x but I can add it next month?
It's up to your discretion, totally optional. I only added it because trivial and checking the result in about.pl is easy
Backported: Pushed to 19.11.x branch for 19.11.24