If there's no news there's no content, a test on new.content is missing.
Created attachment 124246 [details] [review] Bug 28921: Argument "" isn't numeric in numeric gt (>) at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line 23. To test: 1 - Open OPAC main page 2 - Check opac-error.log or plack-opac-error.log for message as above 3 - Apply patch 4 - Open OPAC main page 5 - Check opac-error.log again, there should be no more warnings
Created attachment 124509 [details] [review] Bug 28921: Argument "" isn't numeric in numeric gt (>) at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line 23. To test: 1 - Open OPAC main page 2 - Check opac-error.log or plack-opac-error.log for message as above 3 - Apply patch 4 - Open OPAC main page 5 - Check opac-error.log again, there should be no more warnings Signed-off-by: David Nind <david@davidnind.com>
Testing notes (koha-testing-docker): - I could only get the warning message to appear once (the first time I opened the OPAC home page, flush_memcached and restart_all didn't make any difference, using different browsers didn't either) - After applying the patch I closed down koha-testing-docker and started things up again, there was no warning message in the logs when accessing the OPAC home page
Created attachment 124543 [details] [review] Bug 28921: Argument "" isn't numeric in numeric gt (>) at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line 23. To test: 1 - Open OPAC main page 2 - Check opac-error.log or plack-opac-error.log for message as above 3 - Apply patch 4 - Open OPAC main page 5 - Check opac-error.log again, there should be no more warnings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 124687 [details] [review] Bug 28921: Remove warning from html_helpers.inc Argument "" isn't numeric in numeric gt (>) at /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line 23. To test: 1 - Open OPAC main page 2 - Check opac-error.log or plack-opac-error.log for message as above 3 - Apply patch 4 - Open OPAC main page 5 - Check opac-error.log again, there should be no more warnings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Didier, the warning itself is not a correct commit title. Have a look at https://wiki.koha-community.org/wiki/Commit_messages if you are not familiar with it yet.
Pushed to master for 21.11, thanks to everybody involved!