Bug 29567 - Cataloguing plugins are broken on the batch item mod tool
Summary: Cataloguing plugins are broken on the batch item mod tool
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 28445
Blocks:
  Show dependency treegraph
 
Reported: 2021-11-24 10:56 UTC by Jonathan Druart
Modified: 2021-11-25 09:05 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
21.11.00


Attachments
Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins (2.05 KB, patch)
2021-11-24 10:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins (2.11 KB, patch)
2021-11-24 12:11 UTC, Andrew Nugged
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2021-11-24 10:56:49 UTC
Broken by bug 28445.

See also the FIXME from 
  commit 86156da415141e32e16f2090477be32bda241afb
  Bug 28445: Adjust code to handle regexs
Comment 1 Jonathan Druart 2021-11-24 10:58:52 UTC
Created attachment 127973 [details] [review]
Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins

Broken by bug 28445.

See also the FIXME from
  commit 86156da415141e32e16f2090477be32bda241afb
  Bug 28445: Adjust code to handle regexs

The problem is that the cataloguing plugins inject JS code in the DOM BEFORE the footer
in somes page we have all the JS loaded at the end of the DOM
and so $ (jQuery) is not defined

It's working on additem as we don't have the JS in the footer, but the
batch item mod tool has it there.

Test plan:
Batch edit items and confirm that cataloguing are working correctly with
this patch applied.
Comment 2 Andrew Nugged 2021-11-24 12:11:14 UTC
Created attachment 127974 [details] [review]
Bug 29567: (bug 28445 follow-up) Restore cataloguing plugins

Broken by bug 28445.

See also the FIXME from
  commit 86156da415141e32e16f2090477be32bda241afb
  Bug 28445: Adjust code to handle regexs

The problem is that the cataloguing plugins inject JS code in the DOM BEFORE the footer
in somes page we have all the JS loaded at the end of the DOM
and so $ (jQuery) is not defined

It's working on additem as we don't have the JS in the footer, but the
batch item mod tool has it there.

Test plan:
Batch edit items and confirm that cataloguing are working correctly with
this patch applied.

Signed-off-by: Andrew Nugged <nugged@gmail.com>
Comment 3 Jonathan Druart 2021-11-25 08:48:01 UTC
Skipping QA, this needs to be pushed today.
Comment 4 Jonathan Druart 2021-11-25 09:05:19 UTC
Pushed to master for 21.11, thanks to everybody involved!