Bug 29598 - Add a preference for default borrower's notice language
Summary: Add a preference for default borrower's notice language
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-30 13:25 UTC by Marcel de Rooy
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2021-11-30 13:25:28 UTC
Notice language for a new borrower via staff interface defaults to language of the staff interface user.
In the OPAC self registration does not list the field and the value will be set to the database default called ... 'default'.

Would be nice if we could make that more consistent.
Comment 1 Lari Strand 2023-04-11 08:36:21 UTC
It seems also that on 22.11 the new borrower's (being added via staff interface) language is set to "default" by default and does not follow the selected intranet language selection anymore.

Maybe a syspref (TranslateNoticesDefaultValue or something) that allows you to choose a language from the installed languages for the "default" value would be useful (requires TranslateNotices to be set to "Allow" to apply). If the default language for the new notices language syspref was not set, then the value "default" would be used?
Comment 2 Katrin Fischer 2023-04-11 09:02:15 UTC
(In reply to Lari Strand from comment #1)
> It seems also that on 22.11 the new borrower's (being added via staff
> interface) language is set to "default" by default and does not follow the
> selected intranet language selection anymore.
> 
> Maybe a syspref (TranslateNoticesDefaultValue or something) that allows you
> to choose a language from the installed languages for the "default" value
> would be useful (requires TranslateNotices to be set to "Allow" to apply).
> If the default language for the new notices language syspref was not set,
> then the value "default" would be used?

Hi Lari and Marcel, I believe 'default' for a user added from the staff interface is correct and it also used to work like that.

We rely on the user to pick a language and if we want to pre-select, it would only make sense for the OPAC. The staff user's preference and the user's preference don't necessarily have to be a match.I can think of some cases where this would have led to wrong settings in our libraries.

I remember we had some problems with langauge/lang variable clashes on the borrowers pages in staff, could this be related?
Comment 3 Katrin Fischer 2023-04-11 09:02:47 UTC
In other words... I believe this is a bug.
Comment 4 Katrin Fischer 2023-04-11 21:21:23 UTC
(In reply to Marcel de Rooy from comment #0)
> Notice language for a new borrower via staff interface defaults to language
> of the staff interface user.
> In the OPAC self registration does not list the field and the value will be
> set to the database default called ... 'default'.
> 
> Would be nice if we could make that more consistent.

I can't reproduce this on master:

* TranslateNotices off: Add a new patron. lang = default
* TranslateNotices on: Add a new patron. lang = default
* TranslateNotices on, staff user set to fr-FR. Add new patron. lang = default

Which version did you test with?
Comment 5 Marcel de Rooy 2023-04-17 13:07:43 UTC
(In reply to Katrin Fischer from comment #4)
> (In reply to Marcel de Rooy from comment #0)
> > Notice language for a new borrower via staff interface defaults to language
> > of the staff interface user.
> > In the OPAC self registration does not list the field and the value will be
> > set to the database default called ... 'default'.
> > 
> > Would be nice if we could make that more consistent.
> 
> I can't reproduce this on master:
> 
> * TranslateNotices off: Add a new patron. lang = default
> * TranslateNotices on: Add a new patron. lang = default
> * TranslateNotices on, staff user set to fr-FR. Add new patron. lang =
> default
> 
> Which version did you test with?

My comment dates from 2021. So it must have been fixed in the meantime?
Comment 6 Katrin Fischer 2023-04-23 12:35:36 UTC
> > Which version did you test with?
> 
> My comment dates from 2021. So it must have been fixed in the meantime?

Would be nice to know how and when... but I am closing this one for now.