Bug 30044 - Z39.50/SRU search button broken by update to 19.11.25
Summary: Z39.50/SRU search button broken by update to 19.11.25
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 19.11
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 26102
Blocks:
  Show dependency treegraph
 
Reported: 2022-02-08 11:09 UTC by Alexander Borkowski
Modified: 2022-12-12 21:25 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Borkowski 2022-02-08 11:09:03 UTC
After updating to 19.11.25 the Z39.50 search button in the catalogue search results page (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt) does no longer work. I think that this is because versions 20.05 and up contain the changes made in bug #23885, while 19.11 does not and the backport to 19.11 for #26102 does not take this into account and removes too much code from koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt.

Steps to reproduce:

1. Click on "Search the catalogue"
2. Enter a search term that will give no results
3. Click on the button labeled "Submit"
4. On the page without results that comes up, click on the button labeled "Z39.50/SRU search"
5. Note that nothing happens
Comment 1 Katrin Fischer 2022-02-19 21:32:54 UTC
Adding Wainui as RMaint of 19.11 - I think it might be easiest to revert the change if possible?
Comment 2 wainuiwitikapark 2022-02-21 03:02:17 UTC
(In reply to Katrin Fischer from comment #1)
> Adding Wainui as RMaint of 19.11 - I think it might be easiest to revert the
> change if possible?

So should I revert 26102 on 19.11.x?
Comment 3 wainuiwitikapark 2022-02-21 05:00:39 UTC
Reverted all commits of bug 26102 on 19.11.x
Comment 4 Katrin Fischer 2022-02-21 08:11:36 UTC
I am sorry, I got confused with the bug linked in the description and didn't realize that was the security bug :( We probably need a 19.11 version in that case that doesn't break things?
Comment 5 Jonathan Druart 2022-02-21 09:07:25 UTC
I would not have reverted the changes. How do we process now?
Comment 6 Jonathan Druart 2022-02-21 09:24:40 UTC
I have attached a version of the patches for 19.11.x on bug 26102.
Comment 7 wainuiwitikapark 2022-02-22 00:26:00 UTC
Apologies for that.

I will apply the new 19.11 patches of bug 26102.

Please let me know if there is anything else I need to do to fix it up.
Comment 8 wainuiwitikapark 2022-02-22 00:54:52 UTC
Applied 19.11 patches from bug 26102 to 19.11.x branch
Comment 9 Alexander Borkowski 2022-03-23 09:45:58 UTC
Thank you! The button is working again for us (on 19.11.27).