Bug 30065 - Correct errors in backporting of database updates
Summary: Correct errors in backporting of database updates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: 21.05
Hardware: All All
: P5 - low major
Assignee: Andrew Fuerste-Henry
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-09 16:15 UTC by Andrew Fuerste-Henry
Modified: 2022-12-12 21:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.05.10
Circulation function:

Attachments
Bug 30065: Correct errors in updatedatabase (3.75 KB, patch)
2022-02-09 17:19 UTC, Andrew Fuerste-Henry 		Details | Diff | Splinter Review
Bug 30065: Correct errors in updatedatabase (3.82 KB, patch)
2022-02-09 17:31 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 30065: Correct errors in updatedatabase (3.87 KB, patch)
2022-02-09 17:33 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 30065: Correct errors in updatedatabase (4.37 KB, patch)
2022-02-09 17:37 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2022-02-09 16:15:49 UTC 
Bug 25078 changed how database updates are handled at upgrade for versions 21.11 and later. In backporting bug 29457 and bug 29557 to 21.05.09, I mistakenly followed the new updatedatabase structure. This bug is to correct those errors.

As I understand the changes from 25078, this error won't cause an upgrade to 21.05.09 to fail, but the changes from the two bugs linked above will not be made. Those changes are a correction to a notice script and two informational notes to be output when updatedatabase runs, so the impact here is minimal.
Comment 1 Andrew Fuerste-Henry 2022-02-09 17:19:18 UTC 
Created attachment 130397 [details] [review]
Bug 30065: Correct errors in updatedatabase
Comment 2 Kyle M Hall (khall) 2022-02-09 17:31:39 UTC 
Created attachment 130403 [details] [review]
Bug 30065: Correct errors in updatedatabase

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Kyle M Hall (khall) 2022-02-09 17:33:32 UTC 
Created attachment 130404 [details] [review]
Bug 30065: Correct errors in updatedatabase

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Kyle M Hall (khall) 2022-02-09 17:37:27 UTC 
Created attachment 130405 [details] [review]
Bug 30065: Correct errors in updatedatabase

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Andrew Fuerste-Henry 2022-02-09 17:48:51 UTC 
Pushed to 21.05.x for 21.05.10