Bug 30259 - [Omnibus] Standardize how lists of items are created in notices
Summary: [Omnibus] Standardize how lists of items are created in notices
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 9083 17291 29698
  Show dependency treegraph
 
Reported: 2022-03-09 23:34 UTC by Christopher Brannon
Modified: 2022-03-15 16:14 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2022-03-09 23:34:48 UTC
On all other digests, we can specify item content, and that item content lists all items being listed.  The rest of the template is not repeated.  However, on the checkin/checkout templates, if there are multiple items, the entire template is repeated.  This needs to be updated to work like the other notification digests.
Comment 1 Katrin Fischer 2022-03-10 22:15:16 UTC
This is a formatting issue.

You removed the  ---- before and after the item relevant part. If you add them back, it will create an item list as you expect.

See the examples here:
https://wiki.koha-community.org/wiki/Notices_and_Slips_Library#Item_Check-in_.28Digest.29

I agree items.content would be good or even better the multi-line <item></item> syntax from overdues, because that's more flexible. There is probably also a solution with TT. 

BUT: it can work already :)
Comment 2 Christopher Brannon 2022-03-11 15:35:44 UTC
I would like to keep this open for consideration of having it work like other digests, rather than having it 'work' using some other method.  All the templates should work the same way.  Honestly, when and where the <item> tags are needed in other templates should be listed somewhere on this page.  We shouldn't have to go digging for this info.  But, at the very least, it would be good if checkin/checkout maintained consistency with other notice templates.
Comment 3 Owen Leonard 2022-03-14 18:38:39 UTC
(In reply to Christopher Brannon from comment #2)
> I would like to keep this open for consideration of having it work like
> other digests

I think reopening the report necessitates updating the bug title to be descriptive of the new goal.
Comment 4 Christopher Brannon 2022-03-15 16:14:24 UTC
(In reply to Owen Leonard from comment #3)
> (In reply to Christopher Brannon from comment #2)
> > I would like to keep this open for consideration of having it work like
> > other digests
> 
> I think reopening the report necessitates updating the bug title to be
> descriptive of the new goal.

Katrin already did.