Bug 30504 - Value builder for UNIMARC field 181
Summary: Value builder for UNIMARC field 181
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jérémy Breuillard
QA Contact: Testopia
URL:
Keywords:
Depends on: 29159
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-11 10:20 UTC by Jérémy Breuillard
Modified: 2022-05-20 06:51 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Large patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement for UNIMARC field 181 adds value builders for subfields $a, $b, $c, and $2. These are based on the official UNIMARC codes.
Version(s) released in:


Attachments
Bug 30504: Value builder for field 181 (36.46 KB, patch)
2022-04-11 11:57 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
MT 35334: Value builder for field 181 (36.41 KB, patch)
2022-04-30 00:59 UTC, David Nind
Details | Diff | Splinter Review
Bug 30504: Value builder for field 181 (36.36 KB, patch)
2022-05-18 14:42 UTC, Jérémy Breuillard
Details | Diff | Splinter Review
Bug 30504: Value builder for field 181 (36.36 KB, patch)
2022-05-18 20:00 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jérémy Breuillard 2022-04-11 10:20:23 UTC
It could be easier to have plugins on each subfield for field $181 :
$a, $b, $c and $2

The value builder plugins let you choose a code based on unimarc official documents and depending on the item you want to store in koha
Comment 1 Jérémy Breuillard 2022-04-11 11:57:34 UTC Comment hidden (obsolete)
Comment 2 David Nind 2022-04-30 00:59:12 UTC
Created attachment 134429 [details] [review]
MT 35334: Value builder for field 181

This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items

Test plan:
1)Go to Home > Cataloging > New record
2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2
3)Inputs are writable but notice that no plugins are suggested
4)Apply patch and repeat 1) to 3)
5)Values builders plugins are available for $a, $b, $c and $2

https://bugs.koha-community.org/show_bug.cgi?id=30504

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-04-30 01:09:29 UTC
Testing notes (using koha-testing-docker on master):

- Click field 181's title to display subfields $b and $2 (their visibility is set to collapsed for the default framework)

- Noted that $c has an authorised value list by default: I assume that libraries will remove this link if they want to use the value builder plugin (the authorised value list seems to take priority if it and value builder plugin are both selected)

- I didn't try editing or creating a record a I am not familiar with UNIMARC and there seems to be a lot of required fields!
Comment 4 David Nind 2022-04-30 02:07:36 UTC
I am not sure what happened when I signed off the patch. 

The original patch is listed and there is a new patch starting with MT 35334...

I did my normal:
- git so 1
- git bz attach -e 30504 HEAD

I'm not sure how to fix this - I'm assuming it has something to do with how the patch is formatted.
Comment 5 Victor Grousset/tuxayo 2022-04-30 17:19:05 UTC
Jérémy: On your attachment on comment 1 when clicking on details, we can see in the patch content that the commit has the wrong ticket number. Even if in bugzilla the attachment has the right title.

You need to do git commit --amend to change the commit message to have the right ticket number. (you need to apply the patch from here to have David's version to keep their signoff line)

I marked as obsolete the oldest attachment here so only the one signed off by David remains.
Comment 6 Jérémy Breuillard 2022-05-18 14:42:34 UTC
Created attachment 135122 [details] [review]
Bug 30504: Value builder for field 181

This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items

Test plan:
1)Go to Home > Cataloging > New record
2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2
3)Inputs are writable but notice that no plugins are suggested
4)Apply patch and repeat 1) to 3)
5)Values builders plugins are available for $a, $b, $c and $2

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Jérémy Breuillard 2022-05-18 14:45:05 UTC
(In reply to Victor Grousset/tuxayo from comment #5)
> Jérémy: On your attachment on comment 1 when clicking on details, we can see
> in the patch content that the commit has the wrong ticket number. Even if in
> bugzilla the attachment has the right title.
> 
> You need to do git commit --amend to change the commit message to have the
> right ticket number. (you need to apply the patch from here to have David's
> version to keep their signoff line)
> 
> I marked as obsolete the oldest attachment here so only the one signed off
> by David remains.

Ok, thanks for the comment ! :)
Comment 8 David Nind 2022-05-18 20:00:02 UTC
Created attachment 135163 [details] [review]
Bug 30504: Value builder for field 181

This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items

Test plan:
1)Go to Home > Cataloging > New record
2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2
3)Inputs are writable but notice that no plugins are suggested
4)Apply patch and repeat 1) to 3)
5)Values builders plugins are available for $a, $b, $c and $2

Signed-off-by: David Nind <david@davidnind.com>