Bug 30644 - Cannot delete items
Summary: Cannot delete items
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low blocker (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 29788
Blocks:
  Show dependency treegraph
 
Reported: 2022-04-28 12:44 UTC by Nick Clemens
Modified: 2022-05-17 12:38 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00


Attachments
Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean (985 bytes, patch)
2022-04-28 13:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean (1.02 KB, patch)
2022-04-28 13:54 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-04-28 12:44:16 UTC
The method Koha::Item->messages is not covered by tests!
Comment 1 Jonathan Druart 2022-04-28 13:44:12 UTC
Shame on me
Comment 2 Jonathan Druart 2022-04-28 13:45:38 UTC
Created attachment 134264 [details] [review]
Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean

Fix item deletion

Wrong if/else!

Test plan:
Delete an item
Comment 3 Nick Clemens 2022-04-28 13:54:56 UTC
Created attachment 134265 [details] [review]
Bug 30644: (bug 29788 follow-up) Make Koha::Item->safe_to_delete use Koha::Result::Boolean

Fix item deletion

Wrong if/else!

Test plan:
Delete an item

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Nick Clemens 2022-04-28 13:56:02 UTC
Good catch :-) passing QA
Comment 5 Fridolin Somers 2022-04-28 20:51:15 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄