Bug 30766 - Typo: Cannot cancel receipt. Possible reasons :
Summary: Typo: Cannot cancel receipt. Possible reasons :
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Danyon Sewell
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-05-15 11:48 UTC by Katrin Fischer
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.04, 21.11.11


Attachments
Bug 30766: extra space in Cannot cancel receipt string. (1.12 KB, patch)
2022-07-07 23:00 UTC, Danyon Sewell
Details | Diff | Splinter Review
Tested patch (1.17 KB, patch)
2022-07-07 23:20 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 30766: extra space in Cannot cancel receipt string (1.23 KB, patch)
2022-07-08 08:14 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-05-15 11:48:17 UTC
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:88

Cannot cancel receipt. Possible reasons␠:

The space before : should be removed.
Comment 1 Danyon Sewell 2022-07-07 23:00:23 UTC
Created attachment 137338 [details] [review]
Bug 30766: extra space in Cannot cancel receipt string.

TEST PLAN:

1. Trigger the Cannot cancel receipt error in invoices OR look at the
amended string to see the additional space has been removed.

Sponsored by Catalyst IT
Comment 2 Chris Cormack 2022-07-07 23:20:14 UTC
Created attachment 137344 [details] [review]
Tested patch
Comment 3 Katrin Fischer 2022-07-08 08:14:55 UTC
Created attachment 137374 [details] [review]
Bug 30766: extra space in Cannot cancel receipt string

TEST PLAN:

1. Trigger the Cannot cancel receipt error in invoices OR look at the
amended string to see the additional space has been removed.

Sponsored by Catalyst IT

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Katrin Fischer 2022-07-08 08:16:04 UTC
Thank you, Danyon! Going straight to PQA here.
Comment 5 Tomás Cohen Arazi 2022-07-08 18:26:29 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-08-12 16:42:42 UTC
Backported to 22.05.x for 22.05.04
Comment 7 Arthur Suzuki 2022-08-16 12:47:57 UTC
in 21.11.x for 21.11.11
Comment 8 Victor Grousset/tuxayo 2022-08-19 22:54:26 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.