The single i here seems misplaced: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt:33 i %sEdit %sReserve %s
Created attachment 135059 [details] [review] Bug 30774: Typo: i %sEdit %sReserve %s This patch removes an out of place "i" and replaces it with a space. The patch also removes obsolete CDATA markers in the page's JavaScript. To test, apply the patch and go to Course reserves. - Create a course if necessary, then view the details of your course. - Click the "Add reserves" button. - Enter a barcode or biblionumber. - On the next page, the heading "Reserve [title] for [course]" should look correct, with no extra "i" at the beginning of the line.
Created attachment 135078 [details] [review] Bug 30774: Typo: i %sEdit %sReserve %s This patch removes an out of place "i" and replaces it with a space. The patch also removes obsolete CDATA markers in the page's JavaScript. To test, apply the patch and go to Course reserves. - Create a course if necessary, then view the details of your course. - Click the "Add reserves" button. - Enter a barcode or biblionumber. - On the next page, the heading "Reserve [title] for [course]" should look correct, with no extra "i" at the beginning of the line. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
> The patch also removes obsolete CDATA markers in the page's JavaScript. C
> The patch also removes obsolete CDATA markers in the page's JavaScript. Can you open an enhancement request on the qa-test-tools project please?
Created attachment 135108 [details] [review] Bug 30774: Typo: i %sEdit %sReserve %s This patch removes an out of place "i" and replaces it with a space. The patch also removes obsolete CDATA markers in the page's JavaScript. To test, apply the patch and go to Course reserves. - Create a course if necessary, then view the details of your course. - Click the "Add reserves" button. - Enter a barcode or biblionumber. - On the next page, the heading "Reserve [title] for [course]" should look correct, with no extra "i" at the beginning of the line. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
VIM did it ^^
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
Not backporting, not relevant to 21.11