Bug 30870 - Don't skip tests if Test::Deep is not installed
Summary: Don't skip tests if Test::Deep is not installed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on: 29883
Blocks:
  Show dependency treegraph
 
Reported: 2022-05-31 09:29 UTC by Jonathan Druart
Modified: 2023-06-08 22:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.01


Attachments
Bug 30870: Don't skip tests if Test::Deep if not installed (7.36 KB, patch)
2022-05-31 09:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 30870: Don't skip tests if Test::Deep if not installed (7.41 KB, patch)
2022-05-31 15:19 UTC, David Nind
Details | Diff | Splinter Review
Bug 30870: Don't skip tests if Test::Deep if not installed (7.46 KB, patch)
2022-05-31 17:08 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-05-31 09:29:41 UTC
We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed.
We must assume the module is installed (or skip everywhere).
Comment 1 Jonathan Druart 2022-05-31 09:31:07 UTC
Created attachment 135483 [details] [review]
Bug 30870: Don't skip tests if Test::Deep if not installed

We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed.
We must assume the module is installed

Test plan:
  prove t/db_dependent/Koha.t
should return green in ktd
Comment 2 David Nind 2022-05-31 15:19:12 UTC
Created attachment 135513 [details] [review]
Bug 30870: Don't skip tests if Test::Deep if not installed

We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed.
We must assume the module is installed

Test plan:
  prove t/db_dependent/Koha.t
should return green in ktd

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2022-05-31 17:08:45 UTC
Created attachment 135514 [details] [review]
Bug 30870: Don't skip tests if Test::Deep if not installed

We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed.
We must assume the module is installed

Test plan:
  prove t/db_dependent/Koha.t
should return green in ktd

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2022-05-31 17:09:18 UTC
Works, qa script happy, code looks good, passing QA :)
Comment 5 Tomás Cohen Arazi 2022-06-01 16:42:03 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-06-06 15:38:54 UTC
Pushed to 22.05.x for 22.05.01
Comment 7 Victor Grousset/tuxayo 2022-06-25 21:48:08 UTC
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

And nothing to document, resolving.