We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed (or skip everywhere).
Created attachment 135483 [details] [review] Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd
Created attachment 135513 [details] [review] Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Signed-off-by: David Nind <david@davidnind.com>
Created attachment 135514 [details] [review] Bug 30870: Don't skip tests if Test::Deep if not installed We are using Test::Deep in different tests, but from t/db_dependent/Koha.t the tests are skippted if the module is not installed. We must assume the module is installed Test plan: prove t/db_dependent/Koha.t should return green in ktd Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, qa script happy, code looks good, passing QA :)
Pushed to master for 22.11. Nice work everyone, thanks!
Pushed to 22.05.x for 22.05.01
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. And nothing to document, resolving.