When an item on the patron account was recalled, the list of checkouts in the patron account in the staff interface doesn't load: XHRGEThttp://localhost:8081/cgi-bin/koha/svc/checkouts?borrowernumber=19&_=1654512131603 [HTTP/1.1 500 Internal Server Error 223ms] The method Koha::Recall->item_level_recall is not covered by tests! I have tried with several of the other recall fixes applied, but couldn't get this to go away. If it's a duplicate please close.
The column has been renamed "item_level" Those two occurrences need to be adjusted: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt: [% IF loopro.recall.item_level_recall %] svc/checkouts: if ( $recall->item_level_recall ) {
Created attachment 135882 [details] [review] Bug 30907: Fix incorrect uses of Koha::Recall->item_level_recall This attribute name was changed to *item_level* but this two remaining places kept calling it with the old name. To test, verify things don't explode when looking at checkouts with recalls and also in the log viewer. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 135885 [details] [review] Bug 30907: Fix incorrect uses of Koha::Recall->item_level_recall This attribute name was changed to *item_level* but this two remaining places kept calling it with the old name. To test, verify things don't explode when looking at checkouts with recalls and also in the log viewer. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
No other occurrences found.. passing QA
Pushed to master for 22.11. Nice work everyone, thanks!
For me, the log viewer is still exploding (using koha-testing-docker - this patch is now in master, everything updated) - unless this is a different cause of the error: 1. Enable recalls: set UseRecalls system preference to 'Use'. 2. Ensure recalls RecallsLog system preference is set to 'Log'. 3. Setup rcalls circulation and fines rules: . Recalls allowed (total) = 5 . Recalls per record (count) = 2 . On shelf recalls allowed = 'If any unavailable' . Recall due date interval (day) = 3 . Recall overdue fine amount = 5 . Recall pickup period (day) = 2 4. Checkout an item to a patron: - Patron used: Mary Burton (Midway) - Record used: Programming Perl (biblionumber = 262, one item = 39999000011418, home library = Centerville) 5. Change username/password for a patron and login to the OPAC and place a recall for the item in step 4. - Patron used: Henry Acevedo (Midway) 6. View the checkout and details tab for patron used in step 4: . List of checkouts should display correctly . Message in the title column for the item with a recall: This item has been recalled and the due date updated. 7. Go to Tools > Log viewer and press submit (can limit the module to just Recalls if you wish). 8. Error generated: Template process failed: undef error - The method Koha::Recall->biblionumber is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x55da45a77358)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 385 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 385 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 409 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line 18 Template::Provider::__ANON__('Template::Context=HASH(0x55da45d16528)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 161 Templ .....
(In reply to David Nind from comment #6) > For me, the log viewer is still exploding (using koha-testing-docker - this > patch is now in master, everything updated) - unless this is a different > cause of the error: Have added bug 30971 for this issue.
Backported to 22.05.x for 22.05.01