Bug 30976 - Cover images for biblio should be displayed first
Summary: Cover images for biblio should be displayed first
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords: rel_21_11_candidate
: 31839 (view as bug list)
Depends on: 30234
Blocks:
  Show dependency tree / graph
 
Reported: 2022-06-16 10:35 UTC by Jonathan Druart
Modified: 2023-06-08 22:26 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00,22.05.04,21.11.12
Circulation function:

Attachments
Bug 30976: Display biblio's cover images first (1.12 KB, patch)
2022-06-16 10:35 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 30976: Display biblio's cover images first (1.17 KB, patch)
2022-06-16 13:02 UTC, David Nind 		Details | Diff | Splinter Review
Bug 30976: Display biblio's cover images first (1.23 KB, patch)
2022-07-06 13:37 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
[21.11.x] Bug 30976: Make sure scalar context is used (934 bytes, patch)
2022-09-01 13:10 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-06-16 10:35:06 UTC 
If one add cover images at item's level, then biblio level, the cover images of the items are displayed first on the main "cover slider" at the top of the page.
We should displayed biblio cover images first, then the ones for the items.
Comment 1 Jonathan Druart 2022-06-16 10:35:47 UTC 
Created attachment 136146 [details] [review]
Bug 30976: Display biblio's cover images first

If one add cover images at item's level, then biblio level, the cover images
of the items are displayed first on the main "cover slider" at the top of the page.
We should displayed biblio cover images first, then the ones for the items.
Comment 2 David Nind 2022-06-16 13:02:53 UTC 
Created attachment 136161 [details] [review]
Bug 30976: Display biblio's cover images first

If one add cover images at item's level, then biblio level, the cover images
of the items are displayed first on the main "cover slider" at the top of the page.
We should displayed biblio cover images first, then the ones for the items.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2022-07-06 13:37:29 UTC 
Created attachment 137210 [details] [review]
Bug 30976: Display biblio's cover images first

If one add cover images at item's level, then biblio level, the cover images
of the items are displayed first on the main "cover slider" at the top of the page.
We should displayed biblio cover images first, then the ones for the items.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2022-07-06 13:38:35 UTC 
No regressions found, works as expected.

Passing QA
Comment 5 Tomás Cohen Arazi (tcohen) 2022-07-06 19:49:39 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass (lukeg) 2022-08-12 15:45:41 UTC 
Backported to 22.05.x for 22.05.04
Comment 7 Arthur Suzuki 2022-08-16 09:48:26 UTC 
pushed to 21.11.x for 21.11.11
Comment 8 Victor Grousset/tuxayo 2022-08-19 20:41:29 UTC 
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.
Comment 9 Tomás Cohen Arazi (tcohen) 2022-09-01 13:08:55 UTC 
Hi, this broke 21.11.x detail page. I'm submitting a fix.
Comment 10 Tomás Cohen Arazi (tcohen) 2022-09-01 13:10:57 UTC 
Created attachment 140039 [details] [review]
[21.11.x] Bug 30976: Make sure scalar context is used

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 11 Arthur Suzuki 2022-10-12 08:42:44 UTC 
Thx thomas,
applied to 21.11.x for 21.11.13
Comment 12 Victor Grousset/tuxayo 2022-10-13 15:11:08 UTC 
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.
Comment 13 Jonathan Druart 2022-10-19 08:46:27 UTC 
(In reply to Arthur Suzuki from comment #11)
> Thx thomas,
> applied to 21.11.x for 21.11.13

But "Version(s) release in" have "22.11.00, 22.05.04, 21.11.11"

Are you editing it manually? There is a RMaint script for that!
Comment 14 Jonathan Druart 2022-10-19 08:46:51 UTC 
*** Bug 31839 has been marked as a duplicate of this bug. ***
Comment 15 Arthur Suzuki 2022-10-22 22:08:22 UTC 
Thanks!

Pushed to 21.11 for 21.11.12
Comment 16 Victor Grousset/tuxayo 2022-11-02 01:19:41 UTC 
(In reply to Jonathan Druart from comment #13)
> Are you editing it manually? There is a RMaint script for that!

I do it manually too (I got stuff ready to copy paste so it's quick), especially needed since we now have to assess if documentation is needed or not or maybe. That changes the status and message to write.