Bug 31186 - Search result numbering in OPAC got suppressed
Summary: Search result numbering in OPAC got suppressed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords: regression
: 31182 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-07-19 11:27 UTC by Marcel de Rooy
Modified: 2023-06-08 22:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.05, 21.11.12
Circulation function:

Attachments
Bug 31186: Fix the hidingrules test for result numbering (1.10 KB, patch)
2022-07-19 11:31 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 31186: Fix the hidingrules test for result numbering (1.11 KB, patch)
2022-07-20 14:41 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2022-07-19 11:27:43 UTC 
Trivial fix forthcoming
Comment 1 Marcel de Rooy 2022-07-19 11:31:24 UTC 
Created attachment 137861 [details] [review]
Bug 31186: Fix the hidingrules test for result numbering

We should not test the $hidingrules variable but the number
of keys it contains.

Test plan:
Clear OpacHiddenItems.
Check with and without this patch search result numbering on
the OPAC.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2022-07-19 11:31:53 UTC 
Super trivial
Comment 3 Nick Clemens (kidclamp) 2022-07-20 14:41:51 UTC 
Created attachment 137936 [details] [review]
Bug 31186: Fix the hidingrules test for result numbering

We should not test the $hidingrules variable but the number
of keys it contains.

Test plan:
Clear OpacHiddenItems.
Check with and without this patch search result numbering on
the OPAC.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-07-20 14:54:40 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Katrin Fischer 2022-07-24 21:13:53 UTC 
*** Bug 31182 has been marked as a duplicate of this bug. ***
Comment 6 Lucas Gass (lukeg) 2022-08-23 20:13:57 UTC 
Backported to 22.05.x for 22.05.05
Comment 7 Arthur Suzuki 2022-08-30 09:30:49 UTC 
thx pushed to 21.11.x for 21.11.12
Comment 8 Victor Grousset/tuxayo 2022-09-14 19:32:49 UTC 
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document, marking resolved.