Bug 31311 - Remove GetItemsInfo from labels/label-item-search
Summary: Remove GetItemsInfo from labels/label-item-search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 31306
Blocks: 27272
  Show dependency tree / graph
 
Reported: 2022-08-08 14:22 UTC by Jonathan Druart
Modified: 2023-06-08 22:26 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31311: Remove GetItemsInfo labels/label-item-search (924 bytes, patch)
2022-08-08 14:47 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 31311: Remove GetItemsInfo labels/label-item-search (973 bytes, patch)
2022-08-08 17:38 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 31311: Remove GetItemsInfo labels/label-item-search (1.11 KB, patch)
2022-08-09 14:56 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-08-08 14:22:41 UTC 
Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search_ordered.

Here we are going to deal with labels/label-item-search
Comment 1 Jonathan Druart 2022-08-08 14:47:21 UTC 
Created attachment 138819 [details] [review]
Bug 31311: Remove GetItemsInfo labels/label-item-search

It was commented anyway

Hey, nothing to do here!
Comment 2 Owen Leonard 2022-08-08 17:38:37 UTC 
Created attachment 138845 [details] [review]
Bug 31311: Remove GetItemsInfo labels/label-item-search

It was commented anyway

Hey, nothing to do here!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Nick Clemens (kidclamp) 2022-08-09 14:56:44 UTC 
Created attachment 138921 [details] [review]
Bug 31311: Remove GetItemsInfo labels/label-item-search

It was commented anyway

Hey, nothing to do here!

Amended patch removes refactor comment that referred to this line, maybe?

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-08-09 16:29:46 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!