Bug 31432 - MARC21: Make 245 n and p subfields visible in frameworks by default
Summary: MARC21: Make 245 n and p subfields visible in frameworks by default
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Katrin Fischer
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-21 22:19 UTC by Katrin Fischer
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.13, 21.11.21


Attachments
Bug 31432: Make 245$n$p visible by default in frameworks (1.82 KB, patch)
2023-02-18 11:57 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31432: Make 245$n$p visible by default in frameworks (1.87 KB, patch)
2023-02-18 14:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31432: Make 245$n$p visible by default in frameworks (1.66 KB, patch)
2023-04-15 22:32 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31432: Make 245$n$p visible by default in frameworks (1.75 KB, patch)
2023-04-17 12:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-08-21 22:19:18 UTC
As we now have nice mappings for these in the tables, we should make also sure hat they are visible in the cataloguing editor by default in new installations.
Comment 1 Katrin Fischer 2023-02-18 11:57:04 UTC
Created attachment 146916 [details] [review]
Bug 31432: Make 245$n$p visible by default in frameworks

$n (part_number) and $p (part_name) now have their own
columns in the database, but we are still hiding them
by default. It woudl ease testing and cataloguig if
we changed them to be visible by default in new installations.

To test:
* Check that in your current frameworks when adding a new
  record, 245 n and p are hidden
* Apply the patch and start over: drop your db and run the
  web installer
* Verify that the fields are now visible
Comment 2 Owen Leonard 2023-02-18 14:54:21 UTC
Created attachment 146918 [details] [review]
Bug 31432: Make 245$n$p visible by default in frameworks

$n (part_number) and $p (part_name) now have their own
columns in the database, but we are still hiding them
by default. It woudl ease testing and cataloguig if
we changed them to be visible by default in new installations.

To test:
* Check that in your current frameworks when adding a new
  record, 245 n and p are hidden
* Apply the patch and start over: drop your db and run the
  web installer
* Verify that the fields are now visible

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2023-04-14 07:57:45 UTC
Please explain why you add the third occurrence to hidden=9 ?
Close to 0 on the keyboard, haha?

-          hidden: -6
+          hidden: 9
Comment 4 Katrin Fischer 2023-04-14 09:16:37 UTC
You are right... typo.
Comment 5 Marcel de Rooy 2023-04-14 10:06:06 UTC
        - tagfield: "246"
          tagsubfield: "n"
          liblibrarian: "Number of part/section of a work"
          libopac: "Number of part/section of a work"
          repeatable: 1
          mandatory: 0
          kohafield: ""
          tab: 2
          authorised_value: ""
          authtypecode: ""
          value_builder: ""
          isurl:
          hidden: 9
          frameworkcode: ""
          seealso: ""
          link: ""
          defaultvalue:

        - tagfield: "246"
          tagsubfield: "p"
          liblibrarian: "Name of part/section of a work"
          libopac: "Name of part/section of a work"
          repeatable: 1
          mandatory: 0
          kohafield: ""
          tab: 2
          authorised_value: ""
          authtypecode: ""
          value_builder: ""
          isurl:
          hidden: -6
          frameworkcode: ""
          seealso: ""
          link: ""

I am seeing now that you change field 246. You are out of scope? Or change title and what about 246$p ?
Comment 6 Katrin Fischer 2023-04-15 22:32:12 UTC
Created attachment 149717 [details] [review]
Bug 31432: Make 245$n$p visible by default in frameworks

$n (part_number) and $p (part_name) now have their own
columns in the database, but we are still hiding them
by default. It woudl ease testing and cataloguig if
we changed them to be visible by default in new installations.

To test:
* Check that in your current frameworks when adding a new
  record, 245 n and p are hidden
* Apply the patch and start over: drop your db and run the
  web installer
* Verify that the fields are now visible

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Katrin Fischer 2023-04-15 22:32:44 UTC
Thx Marcel, good catch.
Comment 8 Marcel de Rooy 2023-04-17 12:49:57 UTC
Created attachment 149752 [details] [review]
Bug 31432: Make 245$n$p visible by default in frameworks

$n (part_number) and $p (part_name) now have their own
columns in the database, but we are still hiding them
by default. It woudl ease testing and cataloguig if
we changed them to be visible by default in new installations.

To test:
* Check that in your current frameworks when adding a new
  record, 245 n and p are hidden
* Apply the patch and start over: drop your db and run the
  web installer
* Verify that the fields are now visible

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Tomás Cohen Arazi 2023-04-21 13:37:14 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Jacob O'Mara 2023-05-10 12:53:44 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 11 Lucas Gass 2023-05-15 21:12:23 UTC
Backported to 22.05.x for upcoming 22.05.13
Comment 12 Arthur Suzuki 2023-05-23 14:26:36 UTC
applied to 21.11 for 21.11.21