Bug 31477 - Switch icon for inventory
Summary: Switch icon for inventory
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 31162
Blocks:
  Show dependency treegraph
 
Reported: 2022-08-28 10:31 UTC by Katrin Fischer
Modified: 2023-11-30 16:41 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 31477: Use clipboard icon for inventory (1.48 KB, patch)
2023-11-02 11:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31477: Use clipboard icon for inventory (1.54 KB, patch)
2023-11-02 14:02 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31477: Use clipboard icon for inventory (1.59 KB, patch)
2023-11-02 14:57 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-08-28 10:31:59 UTC
The 'chart' icon doesn's quite capture inventory for me. I think list-check or ballot-check would capture the tool's purpose better. You are working through your items and check what's there or missing...

https://fontawesome.com/icons/clipboard-check?s=solid
Comment 1 Lucas Gass 2022-09-01 17:48:34 UTC
I don't think <i class="fa-solid fa-clipboard-check"></i> is available in Font Awesome 4.
Comment 2 Katrin Fischer 2022-09-05 22:11:45 UTC
That would explain, why I couldn't make it work when I tried... What about list-check - that should be in 2.0?

https://fontawesome.com/icons/list-check?s=solid&f=classic
Comment 3 Katrin Fischer 2023-11-01 20:56:04 UTC
We do have FA 4 now, so it would be a good time to revisit :)
Comment 4 Owen Leonard 2023-11-02 11:09:11 UTC
Created attachment 158245 [details] [review]
Bug 31477: Use clipboard icon for inventory

This patch changes the inventory icon on the cataloging home page. The
"chart" icon is switched for one of a clipboard with a checkmark.

To test, apply the patch and go to the cataloging home page in the staff
interface. Check that the icon on the inventory link looks correct.
Comment 5 Lucas Gass 2023-11-02 14:01:33 UTC
Looks good, trivial change that I think can safely go straight to PQA.
Comment 6 Lucas Gass 2023-11-02 14:02:29 UTC
Created attachment 158262 [details] [review]
Bug 31477: Use clipboard icon for inventory

This patch changes the inventory icon on the cataloging home page. The
"chart" icon is switched for one of a clipboard with a checkmark.

To test, apply the patch and go to the cataloging home page in the staff
interface. Check that the icon on the inventory link looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 David Nind 2023-11-02 14:57:39 UTC
Created attachment 158267 [details] [review]
Bug 31477: Use clipboard icon for inventory

This patch changes the inventory icon on the cataloging home page. The
"chart" icon is switched for one of a clipboard with a checkmark.

To test, apply the patch and go to the cataloging home page in the staff
interface. Check that the icon on the inventory link looks correct.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Tomás Cohen Arazi 2023-11-03 15:05:55 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-11-10 02:27:07 UTC
Enhancement not pushed to 23.05.x