Bug 31749 - Detail view broken
Summary: Detail view broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency tree / graph
 
Reported: 2022-10-12 19:53 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2023-12-28 20:42 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Screenshot (254.81 KB, image/png)
2022-10-12 19:53 UTC, Tomás Cohen Arazi (tcohen) 		Details
Bug 31749: Fix detail display when not display cover images (1.38 KB, patch)
2022-10-12 22:00 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 31749: Fix detail display when not display cover images (1.44 KB, patch)
2022-10-13 06:23 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 31749: Fix detail display when not display cover images (1.50 KB, patch)
2022-10-13 10:32 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2022-10-12 19:53:31 UTC 

    


    


      



        
          Comment 1
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2022-10-12 19:53:54 UTC
        

      






Created attachment 141752 [details]
Screenshot

    


    


      



        
          Comment 2
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2022-10-12 21:40:57 UTC
        

      






It looks fine unless all cover image services are turned off. Then the display is broken.

    


    


      



        
          Comment 3
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2022-10-12 22:00:05 UTC
        

      






Created attachment 141754 [details] [review]
Bug 31749: Fix detail display when not display cover images

To test:
1. Apply patch
2. Have none of the image services turned on:
AmazonCoverImages
LocalCoverImages
IntranetCoce
SyndeticsCovers
3. Look at the detail page, things should look right.
4. Turn on some of these image services, things should still look right.

    


    


      



        
          Comment 4
        

        
          Julian Maurice

        

        
        

        
          2022-10-13 06:23:14 UTC
        

      






Created attachment 141767 [details] [review]
Bug 31749: Fix detail display when not display cover images

To test:
1. Apply patch
2. Have none of the image services turned on:
AmazonCoverImages
LocalCoverImages
IntranetCoce
SyndeticsCovers
3. Look at the detail page, things should look right.
4. Turn on some of these image services, things should still look right.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

    


    


      



        
          Comment 5
        

        
          Martin Renvoize (ashimema)

        

        
        

        
          2022-10-13 10:32:59 UTC
        

      






Created attachment 141791 [details] [review]
Bug 31749: Fix detail display when not display cover images

To test:
1. Apply patch
2. Have none of the image services turned on:
AmazonCoverImages
LocalCoverImages
IntranetCoce
SyndeticsCovers
3. Look at the detail page, things should look right.
4. Turn on some of these image services, things should still look right.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

    


    


      



        
          Comment 6
        

        
          Martin Renvoize (ashimema)

        

        
        

        
          2022-10-13 10:33:52 UTC
        

      






Fixes the bug as described.. Passing QA

    


    


      



        
          Comment 7
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2022-10-13 14:26:40 UTC
        

      






Pushed to master for 22.11.

Nice work everyone, thanks!