Bug 31771 - Add 'page-section' to stock rotation pages
Summary: Add 'page-section' to stock rotation pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 30952
Blocks: 31757
  Show dependency tree / graph
 
Reported: 2022-10-13 12:30 UTC by Martin Renvoize (ashimema)
Modified: 2023-12-28 20:43 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31771: Add page-section to stock rotation pages (8.11 KB, patch)
2022-10-18 22:27 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 31771: Add page-section to stock rotation pages (8.16 KB, patch)
2022-10-18 23:17 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31771: Add page-section to stock rotation pages (8.21 KB, patch)
2022-10-21 13:45 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-10-13 12:30:57 UTC 
We need the page-section div adding to the stock rotation pages to ensure proper contrast for even/odd rows on the tables.
Comment 1 Lucas Gass (lukeg) 2022-10-18 22:27:22 UTC 
Created attachment 142111 [details] [review]
Bug 31771: Add page-section to stock rotation pages

To test:
1. Apply patch
2. Set the system preference 'StockRotation' to enable.
3. Go to Cataloging / Stock rotation
4. Add some new rotas
5. Make sure the page looks good with the new page-section div
Comment 2 David Nind 2022-10-18 23:17:13 UTC 
Created attachment 142120 [details] [review]
Bug 31771: Add page-section to stock rotation pages

To test:
1. Apply patch
2. Set the system preference 'StockRotation' to enable.
3. Go to Cataloging / Stock rotation
4. Add some new rotas
5. Make sure the page looks good with the new page-section div

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-21 13:45:51 UTC 
Created attachment 142393 [details] [review]
Bug 31771: Add page-section to stock rotation pages

To test:
1. Apply patch
2. Set the system preference 'StockRotation' to enable.
3. Go to Cataloging / Stock rotation
4. Add some new rotas
5. Make sure the page looks good with the new page-section div

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-10-21 14:47:15 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!