When using the advanced cataloguing editor, the modal showing the defined keyboard shortcuts no longer works.
I wanted to test the clipboard when running into this - might also be worth having a look.
Created attachment 143135 [details] [review] Bug 31818: Enable table elements in keyboard shortcuts popover This patch updates the whitelist for the popover to ensrue our shortcuts table displays To test: 1 - Open the advanced cataloging editor 2 - Click 'Keyboard shortcuts' 3 - Is empty, be sad 4 - Apply patch 5 - Reload 6 - Click it again 7 - Shortcuts!
Created attachment 143138 [details] [review] Bug 31818: Enable table elements in keyboard shortcuts popover This patch updates the whitelist for the popover to ensrue our shortcuts table displays To test: 1 - Open the advanced cataloging editor 2 - Click 'Keyboard shortcuts' 3 - Is empty, be sad 4 - Apply patch 5 - Reload 6 - Click it again 7 - Shortcuts! Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
(In reply to Andrew Fuerste-Henry from comment #3) > Created attachment 143138 [details] [review] [review] > Bug 31818: Enable table elements in keyboard shortcuts popover > > This patch updates the whitelist for the popover to ensrue our shortcuts > table displays > > To test: > 1 - Open the advanced cataloging editor > 2 - Click 'Keyboard shortcuts' > 3 - Is empty, be sad > 4 - Apply patch > 5 - Reload > 6 - Click it again > 7 - Shortcuts! > > Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> In my testing, I was not able to feel actual sadness in step 3, but maybe we can handle that in a followup.
Created attachment 143493 [details] [review] Bug 31818: Enable table elements in keyboard shortcuts popover This patch updates the whitelist for the popover to ensrue our shortcuts table displays To test: 1 - Open the advanced cataloging editor 2 - Click 'Keyboard shortcuts' 3 - Is empty, be sad 4 - Apply patch 5 - Reload 6 - Click it again 7 - Shortcuts! Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for upcoming 22.05.07 release
applied to 21.11 for 21.11.14
21.05.x not affected, no backport. Nothing to document, marking resolved.