Bug 31827 - Add page-section to list to log viewer
Summary: Add page-section to list to log viewer
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-16 11:30 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31827: Add page-section to list to log viewer (19.58 KB, patch)
2022-11-09 17:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 31827: Add page-section to list to log viewer (19.62 KB, patch)
2022-11-09 21:00 UTC, David Nind
Details | Diff | Splinter Review
Bug 31827: Add page-section to list to log viewer (19.68 KB, patch)
2022-11-09 23:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-10-16 11:30:38 UTC
The log viewer also needs some page-section.

There is also a slight misalignment with the options at the top spilling before their labels.
Comment 1 Owen Leonard 2022-11-09 17:30:49 UTC
Created attachment 143559 [details] [review]
Bug 31827: Add page-section to list to log viewer

This patch adds a "page-section" container div around the log viewer
output.

To test, apply the patch and go to Tools -> Logs.

- Perform a log search which will return results.
- The table of results should appear in a white box.
Comment 2 David Nind 2022-11-09 21:00:37 UTC
Created attachment 143591 [details] [review]
Bug 31827: Add page-section to list to log viewer

This patch adds a "page-section" container div around the log viewer
output.

To test, apply the patch and go to Tools -> Logs.

- Perform a log search which will return results.
- The table of results should appear in a white box.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-09 23:36:44 UTC
Created attachment 143603 [details] [review]
Bug 31827: Add page-section to list to log viewer

This patch adds a "page-section" container div around the log viewer
output.

To test, apply the patch and go to Tools -> Logs.

- Perform a log search which will return results.
- The table of results should appear in a white box.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-10 13:06:14 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!