Bug 31885 - In renew page submit button should be yellow
Summary: In renew page submit button should be yellow
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 31947
  Show dependency treegraph
 
Reported: 2022-10-20 06:28 UTC by Fridolin Somers
Modified: 2023-12-28 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31885: Define submit button as primary in renew page (1.34 KB, patch)
2022-10-20 06:31 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 31885: Define submit button as primary in renew page (1.39 KB, patch)
2022-10-20 07:30 UTC, David Nind
Details | Diff | Splinter Review
Bug 31885: Define submit button as primary in renew page (1.44 KB, patch)
2022-10-20 15:18 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2022-10-20 06:28:13 UTC
Like Bug 31810, submit button in renew page is the most important action on this form, it should be yellow.
Comment 1 Fridolin Somers 2022-10-20 06:31:35 UTC
Created attachment 142226 [details] [review]
Bug 31885: Define submit button as primary in renew page

Submit button in renew page is the most important action on this form, it should be yellow

Test plan :
1) Go to renew page /cgi-bin/koha/circ/renew.pl
2) Check submit button 'Submit' as class 'btn-primary' and is yellow
Comment 2 David Nind 2022-10-20 07:30:43 UTC
Created attachment 142227 [details] [review]
Bug 31885: Define submit button as primary in renew page

Submit button in renew page is the most important action on this form, it should be yellow

Test plan :
1) Go to renew page /cgi-bin/koha/circ/renew.pl
2) Check submit button 'Submit' as class 'btn-primary' and is yellow

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Lucas Gass 2022-10-20 15:18:09 UTC
Created attachment 142260 [details] [review]
Bug 31885: Define submit button as primary in renew page

Submit button in renew page is the most important action on this form, it should be yellow

Test plan :
1) Go to renew page /cgi-bin/koha/circ/renew.pl
2) Check submit button 'Submit' as class 'btn-primary' and is yellow

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2022-10-21 12:59:19 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!