Bug 31942 - Add page-section to admin > authorized values area
Summary: Add page-section to admin > authorized values area
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Martin Renvoize (ashimema)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency tree / graph
 
Reported: 2022-10-24 11:49 UTC by Martin Renvoize (ashimema)
Modified: 2023-06-08 22:28 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 31952: Add page-section to authorized values admin (1.79 KB, patch)
2022-10-24 11:51 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 31952: Add page-section to authorized values admin (1.84 KB, patch)
2022-10-24 13:27 UTC, David Nind 		Details | Diff | Splinter Review
Bug 31952: Add page-section to authorized values admin (1.90 KB, patch)
2022-10-24 15:11 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2022-10-24 11:49:58 UTC 
The authorized values administration area needs page-section classes adding.
Comment 1 Martin Renvoize (ashimema) 2022-10-24 11:51:34 UTC 
Created attachment 142491 [details] [review]
Bug 31952: Add page-section to authorized values admin

This patch adds the page-section container to the authorized_values
administration area.

Test plan
1) Confirm that the AV admin area looks reasonable for all area's of
   display
Comment 2 David Nind 2022-10-24 13:27:15 UTC 
Created attachment 142500 [details] [review]
Bug 31952: Add page-section to authorized values admin

This patch adds the page-section container to the authorized_values
administration area.

Test plan
1) Confirm that the AV admin area looks reasonable for all area's of
   display

https://bugs.koha-community.org/show_bug.cgi?id=31942

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-24 15:11:35 UTC 
Created attachment 142524 [details] [review]
Bug 31952: Add page-section to authorized values admin

This patch adds the page-section container to the authorized_values
administration area.

Test plan
1) Confirm that the AV admin area looks reasonable for all area's of
   display

https://bugs.koha-community.org/show_bug.cgi?id=31942

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-10-24 16:29:10 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!

Note: I didn't notice the bug number error on the patch on pushing.
Comment 5 Katrin Fischer 2022-10-24 16:32:16 UTC 
Me neither... can we do something to fix? If we can't... It would make the one below show in release notes and have this one missing (which is maybe not the worst as all those will be pretty much ignored by normal users)

Bug 31952 - Sending an empty system preference search breaks layout

So... maybe we just need to fix bug 31952 :)