Bug 32050 - Add 'page-section' to calendar page
Summary: Add 'page-section' to calendar page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-31 12:17 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32050: Add 'page-section' to calendar page (56.11 KB, patch)
2022-10-31 12:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32050: Add 'page-section' to calendar page (56.16 KB, patch)
2022-10-31 22:08 UTC, David Nind
Details | Diff | Splinter Review
Bug 32050: Add 'page-section' to calendar page (56.21 KB, patch)
2022-11-01 14:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-10-31 12:17:32 UTC
We need the page-section div added to the calendar page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Owen Leonard 2022-10-31 12:20:59 UTC
Created attachment 142830 [details] [review]
Bug 32050: Add 'page-section' to calendar page

This patch adds a "page-section" div to a couple of areas on the
calendar page.

To test, apply the patch and go to Tools -> Calendar.

The content in the page's two columns should be wrapped in a white box.
Comment 2 David Nind 2022-10-31 22:08:05 UTC
Created attachment 142842 [details] [review]
Bug 32050: Add 'page-section' to calendar page

This patch adds a "page-section" div to a couple of areas on the
calendar page.

To test, apply the patch and go to Tools -> Calendar.

The content in the page's two columns should be wrapped in a white box.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-01 14:55:15 UTC
Created attachment 142889 [details] [review]
Bug 32050: Add 'page-section' to calendar page

This patch adds a "page-section" div to a couple of areas on the
calendar page.

To test, apply the patch and go to Tools -> Calendar.

The content in the page's two columns should be wrapped in a white box.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-11-02 22:28:23 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!