Bug 32082 - CanBookBeReserved with itype option is a different subroutine and should be split out
Summary: CanBookBeReserved with itype option is a different subroutine and should be s...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-03 10:01 UTC by Nick Clemens (kidclamp)
Modified: 2022-11-03 10:11 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2022-11-03 10:01:31 UTC 
The call to this routine with param itemtype is self contained code that in fact checks CanItemtypeBeReserved

Calling it as CanBookBeReturned passes ReservesControlBranch as pickup_location - it's a bad smell