Bug 32146 - Add page-section to course reserves
Summary: Add page-section to course reserves
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency tree / graph
 
Reported: 2022-11-09 13:04 UTC by Katrin Fischer
Modified: 2023-06-08 22:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:

Attachments
Bug 32146: Add page-section to course reserves (38.03 KB, patch)
2022-11-09 15:48 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 32146: Add page-section to course reserves (38.08 KB, patch)
2022-11-09 20:20 UTC, David Nind 		Details | Diff | Splinter Review
Bug 32146: Add page-section to course reserves (38.13 KB, patch)
2022-11-09 23:43 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-09 13:04:48 UTC 
In staff, we need some page-sectioning done for:

* List of course reserves
* Reserves detail page
Comment 1 Owen Leonard 2022-11-09 15:48:40 UTC 
Created attachment 143520 [details] [review]
Bug 32146: Add page-section to course reserves

This patch adds a "page-section" wrapping div to two Course Reserves
templates.

Note: This patch contains indentation changes.

To test, apply the patch and go to Course Reserves.

 - The table of course reserves should appear in a white section.
 - View the details of a course: There should be a white section for the
   list of details at the top and another for the table of reserves.
Comment 2 David Nind 2022-11-09 20:20:23 UTC 
Created attachment 143586 [details] [review]
Bug 32146: Add page-section to course reserves

This patch adds a "page-section" wrapping div to two Course Reserves
templates.

Note: This patch contains indentation changes.

To test, apply the patch and go to Course Reserves.

 - The table of course reserves should appear in a white section.
 - View the details of a course: There should be a white section for the
   list of details at the top and another for the table of reserves.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-09 23:43:10 UTC 
Created attachment 143605 [details] [review]
Bug 32146: Add page-section to course reserves

This patch adds a "page-section" wrapping div to two Course Reserves
templates.

Note: This patch contains indentation changes.

To test, apply the patch and go to Course Reserves.

 - The table of course reserves should appear in a white section.
 - View the details of a course: There should be a white section for the
   list of details at the top and another for the table of reserves.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-11-10 13:06:51 UTC 
Pushed to master for 22.11.

Nice work everyone, thanks!