Bug 32264 - Capitalization/Terminology: Show in Staff client?
Summary: Capitalization/Terminology: Show in Staff client?
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords: Academy
: 32265 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-11-18 10:37 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03


Attachments
Bug 32264: Fix capitalization and terminology: Show in Staff client? (4.23 KB, patch)
2023-02-05 01:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32264: Fix capitalization and terminology: Show in Staff client? (4.28 KB, patch)
2023-02-06 13:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32264: Fix capitalization and terminology: Show in Staff client? (4.34 KB, patch)
2023-02-06 15:56 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-18 10:37:47 UTC
Show in Staff client?

Should be: 
Show in staff interface

Appears in multiple spots:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/search_filters.tt:83 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt:64 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:733
Comment 1 Katrin Fischer 2023-02-05 01:21:00 UTC
Created attachment 146184 [details] [review]
Bug 32264: Fix capitalization and terminology: Show in Staff client?

This fixes several occurences of Staff client to read
staff interface.

To test:
* Activate the search filter feature via the SavedSearchFilters
  system preference
* Do a search in the staff catalogue
* Use the link "save as search filter" on top of the results list
* Verify it reads "Show in Staff client?" in the form
* Go to administration > search filters
* Verify the table has a heading "staff client"
* Edit the filter
* Verify there is the "Show in staff client" again
* Apply patch
* All those spots should now read 'staff interface'
Comment 2 Owen Leonard 2023-02-06 13:58:58 UTC
Created attachment 146274 [details] [review]
Bug 32264: Fix capitalization and terminology: Show in Staff client?

This fixes several occurences of Staff client to read
staff interface.

To test:
* Activate the search filter feature via the SavedSearchFilters
  system preference
* Do a search in the staff catalogue
* Use the link "save as search filter" on top of the results list
* Verify it reads "Show in Staff client?" in the form
* Go to administration > search filters
* Verify the table has a heading "staff client"
* Edit the filter
* Verify there is the "Show in staff client" again
* Apply patch
* All those spots should now read 'staff interface'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass 2023-02-06 15:56:51 UTC
Created attachment 146284 [details] [review]
Bug 32264: Fix capitalization and terminology: Show in Staff client?

This fixes several occurences of Staff client to read
staff interface.

To test:
* Activate the search filter feature via the SavedSearchFilters
  system preference
* Do a search in the staff catalogue
* Use the link "save as search filter" on top of the results list
* Verify it reads "Show in Staff client?" in the form
* Go to administration > search filters
* Verify the table has a heading "staff client"
* Edit the filter
* Verify there is the "Show in staff client" again
* Apply patch
* All those spots should now read 'staff interface'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2023-02-06 22:41:08 UTC
*** Bug 32265 has been marked as a duplicate of this bug. ***
Comment 5 Tomás Cohen Arazi 2023-02-07 13:51:30 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-02-08 16:37:51 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 7 Lucas Gass 2023-02-15 21:12:50 UTC
Doesn't apply clean in 22.05.x, no backport