In English, there is not space before the colon: Completeness of the reproduction code␠: should be Completeness of the reproduction code: in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325h.tt:16
Also: Number of units under embargo␠: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:121
Qualifier type␠: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:49
Created attachment 191819 [details] [review] Bug 32285: Removed spaces before the colons
Created attachment 191834 [details] [review] Bug 32285: Removed spaces before the colons Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 191846 [details] [review] Bug 32285: Removed spaces before the colons Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 191847 [details] [review] Bug 32285: (QA follow-up) Remove additional spaces before colons 325$j This removes two additional spaces before colons for the UNIMARC 325$j value builder (unimarc_field_325j.pl plugin). Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using koha-testing-docker): 1. Start up KTD with UNIMARC: KOHA_MARC_FLAVOUR=unimarc ktd 2. Update the default framwork so the 325$h and 325$j use the respective plugins: - Go to Administartion > Cataloging > MARC bibliographic frameworks - For the default framework select Actions > MARC structure - Search for the 325 tag - Edit the subfields: Actions > Edit subfields - For the 325$h subfield add the unimarc_field_325h.pl plugin - For the 325$j subfield add the unimarc_field_325j.pl plugin 3. Edit any record 4. For the 325 tag, click "Reproduction Note" to show all subfields 5. Click the tag builder icon next to the 325$h subfield 6. Notice that the label for teh field has a space before the colon: - Completeness of the reproduction code : 7. Repeat for the 325$j subfield, and note that all the labels have a space before the colon as well: - Terms of access to the reproduction : - Qualifier type : - Unit under embargo : - Number of units under embargo : 8. Apply the patch 9. Repeat steps 3-7 - there are now no space before the colon for any of the field labels.
Nice work everyone! Pushed to main for 26.05