Bug 32285 - Punctuation: Completeness of the reproduction code␠:, ...
Summary: Punctuation: Completeness of the reproduction code␠:, ...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Ben Foster
QA Contact: David Nind
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2022-11-19 13:49 UTC by Katrin Fischer
Modified: 2026-01-23 14:30 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: Sponsored
Comma delimited list of Sponsors: Catalyst
Crowdfunding goal: 0
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes spaces before the colons for the unimarc_field_325h.pl and unimarc_field_325j.pl value builder form field labels.
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 32285: Removed spaces before the colons (2.29 KB, patch)
2026-01-21 20:20 UTC, Ben Foster
Details | Diff | Splinter Review
Bug 32285: Removed spaces before the colons (2.36 KB, patch)
2026-01-21 21:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 32285: Removed spaces before the colons (2.40 KB, patch)
2026-01-21 22:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 32285: (QA follow-up) Remove additional spaces before colons 325$j (1.63 KB, patch)
2026-01-21 22:13 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-19 13:49:25 UTC
In English, there is not space before the colon:

Completeness of the reproduction code␠:

should be

Completeness of the reproduction code:

in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325h.tt:16
Comment 1 Katrin Fischer 2022-11-19 14:07:06 UTC
Also:

Number of units under embargo␠:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:121
Comment 2 Katrin Fischer 2022-11-19 14:11:20 UTC
Qualifier type␠:
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:49
Comment 3 Ben Foster 2026-01-21 20:20:14 UTC
Created attachment 191819 [details] [review]
Bug 32285: Removed spaces before the colons
Comment 4 Katrin Fischer 2026-01-21 21:09:22 UTC
Created attachment 191834 [details] [review]
Bug 32285: Removed spaces before the colons

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 David Nind 2026-01-21 22:13:41 UTC
Created attachment 191846 [details] [review]
Bug 32285: Removed spaces before the colons

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2026-01-21 22:13:43 UTC
Created attachment 191847 [details] [review]
Bug 32285: (QA follow-up) Remove additional spaces before colons 325$j

This removes two additional spaces before colons for the UNIMARC 325$j
value builder (unimarc_field_325j.pl plugin).

Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2026-01-21 22:14:39 UTC
Testing notes (using koha-testing-docker):
1. Start up KTD with UNIMARC: KOHA_MARC_FLAVOUR=unimarc ktd
2. Update the default framwork so the 325$h and 325$j use the respective plugins:
   - Go to Administartion > Cataloging > MARC bibliographic frameworks
   - For the default framework select Actions > MARC structure
   - Search for the 325 tag
   - Edit the subfields: Actions > Edit subfields
   - For the 325$h subfield add the unimarc_field_325h.pl plugin
   - For the 325$j subfield add the unimarc_field_325j.pl plugin
3. Edit any record
4. For the 325 tag, click "Reproduction Note" to show all subfields
5. Click the tag builder icon next to the 325$h subfield
6. Notice that the label for teh field has a space before the colon:
   - Completeness of the reproduction code :
7. Repeat for the 325$j subfield, and note that all the labels have a space before the colon as well:
  - Terms of access to the reproduction :
  - Qualifier type :
  - Unit under embargo :
  - Number of units under embargo :
8. Apply the patch
9. Repeat steps 3-7 - there are now no space before the colon for any of the field labels.
Comment 8 Lucas Gass (lukeg) 2026-01-23 14:30:02 UTC
Nice work everyone!

Pushed to main for 26.05