Bug 32299 - Add page-section to Z39.50/SRU results (cat)
Summary: Add page-section to Z39.50/SRU results (cat)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Auld
QA Contact: Testopia
URL: /cgi-bin/koha/cataloguing/z3950_searc...
Keywords:
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-11-20 13:01 UTC by Katrin Fischer
Modified: 2024-07-04 20:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:


Attachments
Bug 32299: Add page-section to Z39.50 results (22.78 KB, patch)
2022-11-22 14:16 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 32299: Add page-section to Z39.50 results (22.80 KB, patch)
2022-11-22 15:49 UTC, Hammat wele
Details | Diff | Splinter Review
Bug 32299: Add page-section to Z39.50 results (22.85 KB, patch)
2022-11-22 21:30 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-11-20 13:01:29 UTC
When searching Z39.50 the result list should have a page-section on the table.
Comment 1 Martin Renvoize (ashimema) 2022-11-22 14:16:07 UTC
Created attachment 144155 [details] [review]
Bug 32299: Add page-section to Z39.50 results

Test plan
Step 1: Navigate to Cataloguing module and click 'New from Z39.50/SRU' to start a search
Step 2: Carry out a search
Step 3: Confirm that the white background to the table of results is missing
Step 4: Apply patch
Step 6: Repeat search
Step 7: Confirm that the white background is now showing.
Comment 2 Martin Renvoize (ashimema) 2022-11-22 14:19:03 UTC
We trialled a slightly different workflow on this one, Andrew submitted a pull-request to the PTFS Europe mirror of the community repository and then I extracted it to upload here.
Comment 3 Hammat wele 2022-11-22 15:49:05 UTC
Created attachment 144160 [details] [review]
Bug 32299: Add page-section to Z39.50 results

Test plan
Step 1: Navigate to Cataloguing module and click 'New from Z39.50/SRU' to start a search
Step 2: Carry out a search
Step 3: Confirm that the white background to the table of results is missing
Step 4: Apply patch
Step 6: Repeat search
Step 7: Confirm that the white background is now showing.

Signed-off-by: Hammat Wele <hammat.wele@inlibro.com>
Comment 4 Nick Clemens (kidclamp) 2022-11-22 21:30:47 UTC
Created attachment 144176 [details] [review]
Bug 32299: Add page-section to Z39.50 results

Test plan
Step 1: Navigate to Cataloguing module and click 'New from Z39.50/SRU' to start a search
Step 2: Carry out a search
Step 3: Confirm that the white background to the table of results is missing
Step 4: Apply patch
Step 6: Repeat search
Step 7: Confirm that the white background is now showing.

Signed-off-by: Hammat Wele <hammat.wele@inlibro.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-11-23 12:48:27 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!