Bug 32323 - Correct focus state of some DataTables controls
Summary: Correct focus state of some DataTables controls
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30952
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-22 17:08 UTC by Owen Leonard
Modified: 2022-11-23 09:14 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of the button focus state (17.00 KB, image/png)
2022-11-22 17:08 UTC, Owen Leonard
Details
Bug 32323: Correct focus state of some DataTables controls (3.13 KB, patch)
2022-11-22 17:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32323: Correct focus state of some DataTables controls (3.17 KB, patch)
2022-11-22 22:59 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-11-22 17:08:57 UTC
Created attachment 144166 [details]
Screenshot of the button focus state

If you use the tab key to navigate through DataTables controls, some of the buttons have a style which is out of place in our design. See screenshot attached.
Comment 1 Owen Leonard 2022-11-22 17:20:20 UTC
Created attachment 144168 [details] [review]
Bug 32323: Correct focus state of some DataTables controls

This patch makes changes to the style of some DataTable controls in
order to make hover, active, and focus states more consistent.

To test, apply the patch and rebuild the staff interface css.

View a page that has a DataTable showing controls like "Columns,"
"Export," and "Configure." For example: Saved reports, Libraries,
Overdues.

 - Click the DataTables search form to put cursor focus there.
 - Use the tab key to move through the next buttons.
 - The style should now be more consistent with the appearance of other
   similar buttons in the staff client.
 - Test with and without text in the search filter.
 - Test pages which don't have the full set of controls, e.g. the
   table of of a patron's checkouts.
Comment 2 David Nind 2022-11-22 22:59:13 UTC
Created attachment 144179 [details] [review]
Bug 32323: Correct focus state of some DataTables controls

This patch makes changes to the style of some DataTable controls in
order to make hover, active, and focus states more consistent.

To test, apply the patch and rebuild the staff interface css.

View a page that has a DataTable showing controls like "Columns,"
"Export," and "Configure." For example: Saved reports, Libraries,
Overdues.

 - Click the DataTables search form to put cursor focus there.
 - Use the tab key to move through the next buttons.
 - The style should now be more consistent with the appearance of other
   similar buttons in the staff client.
 - Test with and without text in the search filter.
 - Test pages which don't have the full set of controls, e.g. the
   table of of a patron's checkouts.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2022-11-23 09:14:17 UTC
Where is coming from #ADADAD?