Bug 32570 - City is duplicated in patron search if the patron has both city and state
Summary: City is duplicated in patron search if the patron has both city and state
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-04 23:02 UTC by Lucas Gass
Modified: 2023-12-28 20:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03,22.05.10


Attachments
Bug 32570: Display patron.state correctly (1.36 KB, patch)
2023-01-04 23:06 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 32570: Display patron.state correctly (1.41 KB, patch)
2023-01-05 13:23 UTC, David Nind
Details | Diff | Splinter Review
Bug 32570: Display patron.state correctly (1.46 KB, patch)
2023-01-30 22:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-01-04 23:02:51 UTC
To recreate:

1. Have a patron with both a city and state in their Main address.
2. Do a patron search that will return that patron among others.
3. Notice the patroncity will say something like Centerville, Centerville: repeating the city but no state.
Comment 1 Lucas Gass 2023-01-04 23:06:29 UTC
Created attachment 145050 [details] [review]
Bug 32570: Display patron.state correctly

To test:
1. Have a patron with both a city and state in their Main address.
2. Do a patron search that will return that patron among others.
3. Notice the patroncity will say something like Centerville, Centerville: repeating the city but no state.
4. Apply patch
5. Try step 2 again, this time the city, state should display correctly.
Comment 2 David Nind 2023-01-05 13:23:00 UTC
Created attachment 145061 [details] [review]
Bug 32570: Display patron.state correctly

To test:
1. Have a patron with both a city and state in their Main address.
2. Do a patron search that will return that patron among others.
3. Notice the patroncity will say something like Centerville, Centerville: repeating the city but no state.
4. Apply patch
5. Try step 2 again, this time the city, state should display correctly.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-01-30 22:44:45 UTC
Created attachment 145826 [details] [review]
Bug 32570: Display patron.state correctly

To test:
1. Have a patron with both a city and state in their Main address.
2. Do a patron search that will return that patron among others.
3. Notice the patroncity will say something like Centerville, Centerville: repeating the city but no state.
4. Apply patch
5. Try step 2 again, this time the city, state should display correctly.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-01-31 13:23:34 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Jacob O'Mara 2023-01-31 18:11:12 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 6 Lucas Gass 2023-02-03 21:58:45 UTC
Backported to 22.05.x for upcoming 22.05.10
Comment 7 Arthur Suzuki 2023-02-17 09:52:05 UTC
on branch 21.11.x : missing koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format-address.inc
can't backport