Bug 32892 - Email template used when generating DISCHARGE PDF
Summary: Email template used when generating DISCHARGE PDF
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Testopia
URL:
Keywords:
Depends on: 14251
Blocks:
  Show dependency tree / graph
 
Reported: 2023-02-06 18:27 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2023-02-06 18:27 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2023-02-06 18:27:19 UTC 
The generated PDF discharge letter always picks the 'email' transport by default. This means users expecting to define a 'print' version of the discharge notice get confgused and/or wrong results.


This was highlighted by bug 14251, which fixed styling the PDF with CSS, which is only picked if the 'email' transport letter is used.

It is trivial to see this doesn't work as no transport is passed to GetPreparedLetter, which then defaults to 'email'.