Bug 33005 - Use template wrapper for breadcrumbs: Acquisitions part 3
Summary: Use template wrapper for breadcrumbs: Acquisitions part 3
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-02-18 14:46 UTC by Owen Leonard
Modified: 2023-12-28 20:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3 (15.95 KB, patch)
2023-02-18 15:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33005: (follow-up) Add spans for translatability (8.96 KB, patch)
2023-02-24 12:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3 (15.99 KB, patch)
2023-04-06 16:05 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33005: (follow-up) Add spans for translatability (9.00 KB, patch)
2023-04-06 16:05 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33005: (follow-up) Add spans for translatability (9.05 KB, patch)
2023-04-09 11:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33005: (QA follow-up) Update breadcrumb when editing a vendor (1.30 KB, patch)
2023-04-09 11:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3 (15.99 KB, patch)
2023-04-09 11:19 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33005: (follow-up) Add spans for translatability (9.05 KB, patch)
2023-04-09 11:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33005: (QA follow-up) Update breadcrumb when editing a vendor (1.30 KB, patch)
2023-04-09 11:20 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 (17.31 KB, patch)
2023-04-09 11:21 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33001: (follow-up) Add spans for translatability (7.79 KB, patch)
2023-04-09 11:21 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-02-18 14:46:11 UTC
To continue the process started by Bug 32507, this patch will update more templates in acquisitions so that they use the new template wrapper for breadcrumbs.

- newordersuggestion.tt
- ordered.tt
- orderreceive.tt
- parcel.tt
- parcels.tt
- spent.tt
- supplier.tt
- uncertainprice.tt
- z3950_search.tt
Comment 1 Owen Leonard 2023-02-18 15:32:31 UTC
Created attachment 146922 [details] [review]
Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3

This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Acquisitions ->
  -> All available funds table
     -> Ordered
     -> Spent
  -> Vendor
     -> Vendor details
     -> Uncertain prices
     -> Receive shipments (must have at least one open basket)
        -> If necessary, receive a new shipment. Or click an
           invoice number to reach the "receive orders" page.
           -> Click "Receive" in the table listing baskets.
     -> Basket -> Add to basket
        -> From a suggestion
        -> From an external source
Comment 2 Owen Leonard 2023-02-24 12:48:32 UTC
Created attachment 147323 [details] [review]
Bug 33005: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>
Comment 3 ByWater Sandboxes 2023-04-06 16:05:22 UTC
Created attachment 149241 [details] [review]
Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3

This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Acquisitions ->
  -> All available funds table
     -> Ordered
     -> Spent
  -> Vendor
     -> Vendor details
     -> Uncertain prices
     -> Receive shipments (must have at least one open basket)
        -> If necessary, receive a new shipment. Or click an
           invoice number to reach the "receive orders" page.
           -> Click "Receive" in the table listing baskets.
     -> Basket -> Add to basket
        -> From a suggestion
        -> From an external source

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 4 ByWater Sandboxes 2023-04-06 16:05:24 UTC
Created attachment 149242 [details] [review]
Bug 33005: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 5 Andrew Auld 2023-04-06 16:06:06 UTC
All pages and links checked. Lovely!
Comment 6 Katrin Fischer 2023-04-09 11:19:21 UTC
Created attachment 149340 [details] [review]
Bug 33005: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Katrin Fischer 2023-04-09 11:19:24 UTC
Created attachment 149341 [details] [review]
Bug 33005: (QA follow-up) Update breadcrumb when editing a vendor

When editing a vendor the last part of the breadcrumbs read:
Update: <vendor>

This is very unusual, so updated to the standard wording:
Modify <vendor>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2023-04-09 11:19:58 UTC
Created attachment 149342 [details] [review]
Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3

This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Acquisitions ->
  -> All available funds table
     -> Ordered
     -> Spent
  -> Vendor
     -> Vendor details
     -> Uncertain prices
     -> Receive shipments (must have at least one open basket)
        -> If necessary, receive a new shipment. Or click an
           invoice number to reach the "receive orders" page.
           -> Click "Receive" in the table listing baskets.
     -> Basket -> Add to basket
        -> From a suggestion
        -> From an external source

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 9 Katrin Fischer 2023-04-09 11:20:01 UTC
Created attachment 149343 [details] [review]
Bug 33005: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2023-04-09 11:20:04 UTC
Created attachment 149344 [details] [review]
Bug 33005: (QA follow-up) Update breadcrumb when editing a vendor

When editing a vendor the last part of the breadcrumbs read:
Update: <vendor>

This is very unusual, so updated to the standard wording:
Modify <vendor>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Katrin Fischer 2023-04-09 11:21:20 UTC
Created attachment 149345 [details] [review]
Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2

This patch updates several acquisitions-related templates so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Acquisitions ->
  - Late orders,
    - moddeliverydate.tt
    - modordernotes.tt
    -- These two templates aren't linked to from anywhere, but
       you can navigate directly to:
       http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and
       http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1

  - Order search, order search results
  - Invoice search,
    - Invoice details,
      - Invoice files
  - Vendor -> Basket -> Add to basket ->
    - From a new (empty) record
    - From existing orders (copy)
    - From a subscription

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2023-04-09 11:21:22 UTC
Created attachment 149346 [details] [review]
Bug 33001: (follow-up) Add spans for translatability

This patch finds places in the updated breadcrumbs markup where a
translatable string is isolated in a way that makes it hard for the
translation script to find it, and wraps these strings with <span>

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Tomás Cohen Arazi 2023-04-12 14:44:13 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 14 Jacob O'Mara 2023-04-16 20:37:30 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.