Bug 33079 - Misaligned field in the duplicate order form
Summary: Misaligned field in the duplicate order form
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-27 17:54 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:43 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 33082: Add yellow buttons and page sections to 'copy order' pages (3.47 KB, patch)
2023-02-27 21:47 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-02-27 17:54:00 UTC
The Statistic 1 field is misaligned in the duplicate order form (acqui/duplicate_orders).

To get there :
1. Make sure you have budgets, funds and vendors
2. In Acquisitions, search for a vendor
3. Create a basket
4. Add an order to that basket (Order from new (empty) record is easiest)
5. Add to the basket again, choosing the "From existing orders (copy)" option
6. Search for you previous order
7. Check the order and click Next
   --> Statistics 1 field is misaligned
Comment 1 Katrin Fischer 2023-02-27 21:45:00 UTC
This appears to have been fixed on recent master :) But I've filed some patch for page-sections and buttons:
Bug 33082 - Add yellow buttons and page sections to 'copy order' pages
Comment 2 Katrin Fischer 2023-02-27 21:47:21 UTC
Created attachment 147470 [details] [review]
Bug 33082: Add yellow buttons and page sections to 'copy order' pages

When creating a new order from an existing order (copy),
there was no page section on the search results and the
submit buttons were not yellow (primary).

To test:
1. Make sure you have budgets, funds and vendors
2. In Acquisitions, search for a vendor
3. Create a basket
4. Add an order to that basket (Order from new (empty) record is easiest)
5. Add to the basket again, choosing the "From existing orders (copy)" option
6. Search for you previous order
7. The table of ordres has no white background (missing page-section) and
   the "Next" button is not yellow
8. Check the order and click Next
9. The "Duplicate orders" button is not yellow
10. Apply patch
11. Verify buttons are now yellow and the table has a white background
Comment 3 Katrin Fischer 2023-02-27 21:49:42 UTC
...patch to be found on the right bug now.
Comment 4 Caroline Cyr La Rose 2023-02-27 21:53:24 UTC
Ok I just pulled and I still see it misaligned...https://snipboard.io/MwDYSm.jpg

Do I have to build something to see the correction?